Release first thing tomorrow? I think everything w...
# announce
h
Release first thing tomorrow? I think everything we wanted is landing this evening / tomorrow
w
yea.
@clean-city-64472: ^ cc
🙏 1
h
I've made the change to issue a warning if the constraints file doesn't cover all the requirements, am writing a test for that logic now.
Done
Waiting for CI and any last review comments
w
@happy-kitchen-89482, @hundreds-father-404: should we land https://github.com/pantsbuild/pants/pull/10409, or do you want to do the option first?
h
I think likely wait because the semantics are going to change a lot with that. If I understand the proposal correctly, it’s no longer at all about generated subtarget vs. original target. It’s solely about if the field is set for that target. We now have a safety valve for cycles via
!
. Not a great safety valve, but it works.
w
k. i’m fine with waiting.
given that, is there anything else we want in, or should i start cutting?
h
Only https://github.com/pantsbuild/pants/pull/10410. Outside of that one naming suggestion, I think it’s ready, unless we want to wait to include
repl
in it. That’s fine either way with me
h
Cutting is fine for me, I merged the two changes I wanted in
w
@hundreds-father-404: 🚢
https://github.com/pantsbuild/pants/pull/10413 is also green, in case anyone wants to stamp it…
h
Thanks. I’ll make the naming changes in the Repl followup today to not block the release. Please feel free to hit merge. Still getting ready
w
k
hey folks: please hold off on landing things until the release lands, unless you think the something needs to be in the release… in which case, please ping me!
👍 1
release landed a little while ago, so embargo is off! thank you.
❤️ 1
c
is there a delay until it hits pypi?
w
oh, sorry. “release prep landed”
the release itself is running.
eta 10
c
ok cool - i'm standing by
w
@clean-city-64472: ok, it’s technically out. just going to send the email. https://pypi.org/project/pantsbuild.pants/2.0.0.dev4/
💯 2