https://pantsbuild.org/ logo
#announce
Title
# announce
h

hundreds-father-404

07/28/2020, 12:25 AM
Are we still doing a dev release today? The fixes I needed landed.
w

witty-crayon-22786

07/28/2020, 12:30 AM
apparently i caused a pretty significant perf regression with #10441… sigh.
so new target would be tomorrow morning for a release. sorry.
h

hundreds-father-404

07/28/2020, 12:31 AM
No worries. The regression is that the inference is expensive to do?
w

witty-crayon-22786

07/28/2020, 12:32 AM
yea. guessing that it’s because none of the AncestorFiles requests are memoized because they’re all for unique sets
👍 1
so… hopefully not too bad.
h

hundreds-father-404

07/28/2020, 12:32 AM
What would be the remedy, then?
w

witty-crayon-22786

07/28/2020, 12:33 AM
either one request per file, or a recursive-upward implementation.
it’s possible that if we turn on
imports
inference by default we could use the module mapping too.
or regardless. will see.
h

hundreds-father-404

07/28/2020, 12:39 AM
inference by default we could use the module mapping too
This might make a lot of sense. And then it’s easier to convince people to turn on import inference A key detail for me is that you can still turn off all inference if you want to avoid any perf hit.
w

witty-crayon-22786

07/28/2020, 4:15 PM
ok, i’d like to get https://github.com/pantsbuild/pants/pull/10491 in and then cut the release. if folks could hold off on landing things that don’t block their other work, it would be appreciated.
👍 1
h

hundreds-father-404

07/28/2020, 4:19 PM
Sounds good. I wanted to get
--use-first-matching-interpreter
if possible, but it won’t be ready in time. Have to do the Pex release right now, and then land the Pants PR. We shouldn’t block the release more
w

witty-crayon-22786

07/28/2020, 6:14 PM
ok, this landed: feel free to merge!
❤️ 1