Are we still doing a dev release today? The fixes ...
# announce
h
Are we still doing a dev release today? The fixes I needed landed.
w
apparently i caused a pretty significant perf regression with #10441… sigh.
so new target would be tomorrow morning for a release. sorry.
h
No worries. The regression is that the inference is expensive to do?
w
yea. guessing that it’s because none of the AncestorFiles requests are memoized because they’re all for unique sets
👍 1
so… hopefully not too bad.
h
What would be the remedy, then?
w
either one request per file, or a recursive-upward implementation.
it’s possible that if we turn on
imports
inference by default we could use the module mapping too.
or regardless. will see.
h
inference by default we could use the module mapping too
This might make a lot of sense. And then it’s easier to convince people to turn on import inference A key detail for me is that you can still turn off all inference if you want to avoid any perf hit.
w
ok, i’d like to get https://github.com/pantsbuild/pants/pull/10491 in and then cut the release. if folks could hold off on landing things that don’t block their other work, it would be appreciated.
👍 1
h
Sounds good. I wanted to get
--use-first-matching-interpreter
if possible, but it won’t be ready in time. Have to do the Pex release right now, and then land the Pants PR. We shouldn’t block the release more
w
ok, this landed: feel free to merge!
❤️ 1