#announce
Title
h
hundreds-father-404
10/09/2020, 5:35 PMShould today be 2.0.0rc0 or 2.0.0b4? All the feature work should be done within this release, once I land gRPC.
I believe there are a few bugs we know about:
• some Pex issues John has been working on
• Ctrl-c issues Greg is working on
Cc @happy-kitchen-89482 @hundreds-breakfast-49010 @enough-analyst-54434
John, do you have an ETA for the next Pex release? I can wait to do the Pants release till the weekend or Monday, we should include the proxy fixes so Thales can upgrade
f
fast-nail-55400
10/09/2020, 5:37 PMIf there are still ctrl-c issues, I would call this b4
h
hundreds-father-404
10/09/2020, 5:37 PM+1
h
happy-kitchen-89482
10/09/2020, 5:37 PMI think greg merged the ctrl-c fix
h
hundreds-father-404
10/09/2020, 5:38 PMIt resulted in repl being really laggy. But he fixed that last night iiuc by reverting the ctrl-c fix. I’m not sure where we’re at
e
enough-analyst-54434
10/09/2020, 5:38 PMThe 2.1.18 release should be this afternon: https://github.com/pantsbuild/pex/issues/1053
Have 1 item to be reviewed, one I'm still working on.
👍 1
h
happy-kitchen-89482
10/09/2020, 5:39 PMI believe he has a narrower fix for just the repl issue, maybe that's not merged yet
h
hundreds-breakfast-49010
10/09/2020, 6:01 PMthe narrower fix for the repl issue was https://github.com/pantsbuild/pants/pull/10930, which is merged
👍 1
I havne't been able to find any cases so far where ctrl-c really breaks now, although in the medium-term I still think getting that port to the rust nailgun client, and then using heartbeats, and then switching away from the signal-based mechanism for controlling pantsd will be useful
but that should be an after-2.0.0 thing
h
happy-kitchen-89482
10/09/2020, 6:21 PMOK so sounds like we can close the signal handling issue!
Cool so we have one remaining 2.0.0 blocker, which is the grpc support
👍 1
And @hundreds-father-404, sounds like you're on top of that
h
hundreds-father-404
10/09/2020, 6:25 PMOkay so this should be rc0? Cool
e
enough-analyst-54434
10/09/2020, 10:46 PMhttps://github.com/pantsbuild/pants/pull/10938 concludes the Pex activity needed on the Pants side.
h
hundreds-father-404
10/09/2020, 10:46 PMThank you, John!
e
enough-analyst-54434
10/09/2020, 11:20 PMYou're welcome. That's in master now.
h
hundreds-father-404
10/09/2020, 11:22 PMThanks. @happy-kitchen-89482 are you aiming to get your setup.py change improvement in rc0? I’m putting up the
s/python_binary/pex_binaryh
happy-kitchen-89482
10/09/2020, 11:44 PMNo, I don't think so, still figuring out what it should look like.
Might cherry pick it to rc1
👍 1
h
hundreds-father-404
10/11/2020, 10:09 PMAre we making a release branch for 2.0, or keep using the master branch?
f
fast-nail-55400
10/11/2020, 10:58 PMwe should make a release branch, there may be small fixes we do for 2.0.X releases, right?
leaving
masterh
hundreds-father-404
10/11/2020, 11:00 PMThe main question is if we will be making fundamental changes intended for 2.1.x in the next week or two, in which we’re focused almost exclusively on getting out 2.0.0
For example, I don’t suspect we’re going to do a 2.1.0.dev0 release until 2.0.0 is released
f
fast-nail-55400
10/11/2020, 11:06 PMI’d want to add remote caching this week onto
masterand that should not end up in 2.0.0 given the late stage
h
hundreds-father-404
10/11/2020, 11:12 PMOkay, that’s reasonable. Thanks
h
happy-kitchen-89482
10/12/2020, 1:24 AMYeah, release branch is the normal thing we do for an rc, so we should do that here.