https://pantsbuild.org/ logo
e

enough-analyst-54434

12/14/2020, 11:46 PM
Urg, the Pip legacy resolver has regressed wrt constraints files. If the constraints file contains any requirements not in the resolved set (which will ~always be the case for Pants use) it raises an AssertionError. Using the 2020-resolver all is well. I did not want to mix the Pex upgrade with switching the resolver too.
😕 1
Alright, I think the only thing to do here is file an issue / fix PR against Pip and then update the pantsbuild/pip fork with the same PR and have Pex use that for a bit 😕.
I have https://github.com/pypa/pip/pull/9301 away to fix this issue in Pip, but I'm pessimistically moving ahead with https://github.com/pantsbuild/pip/pull/8 to allow a release of Pex against a patched version of Pip 20.3.* until / if Pip resolves the issue.
w

witty-crayon-22786

12/15/2020, 9:07 PM
i think that i had been assuming that Pants would have a flag to control the resolver, and would default to the previous resolver for at least one release?
does that help here?
e

enough-analyst-54434

12/15/2020, 9:07 PM
The bug is in the previous resolver
w

witty-crayon-22786

12/15/2020, 9:07 PM
ah, got it.
e

enough-analyst-54434

12/15/2020, 9:07 PM
So it does not help
They introduced a regression - works fine in new resolver.
w

witty-crayon-22786

12/15/2020, 9:08 PM
yea, misread, sorry.
let me know if there is anything i can do to help. will hold off on all releases right now.
e

enough-analyst-54434

12/15/2020, 10:46 PM
Thanks. Just reviews. This one for Pex: https://github.com/pantsbuild/pex/pull/1143 Another one after 2.1.24 release based on that in Pants.
👀 1
w

witty-crayon-22786

12/15/2020, 10:59 PM
🚢
e

enough-analyst-54434

12/16/2020, 1:17 AM
Alright, cherry-picks coming here presentlyish. Thanks Stu.
👍 1
https://github.com/pantsbuild/pants/pull/11317 is the last one for the 1.30.x branch. That was totally manual - not a cherry-pick.
And 1.30.x is almost surely going to bleed into tomorrow. I'm happy to deal with that release @witty-crayon-22786
w

witty-crayon-22786

12/16/2020, 4:21 AM
thanks, that would be appreciated.