when really we only need to pass the root dir