So I've fixed this bug: <https://github.com/pantsb...
# general
d
So I've fixed this bug: https://github.com/pantsbuild/pants/issues/2320, but have broken two tests (well, one test, copy pasted) in doing so. The tests don't appear to be strictly necessary. Can I get some opinions on removing vs re-writing them? From tests/python/pants_test/backend/jvm/tasks/test_checkstyle_integration.py:```def test_checkstyle_cached(self): with self.temporary_cachedir() as cache: with self.temporary_workdir() as workdir: args = [ 'clean-all', 'compile.checkstyle', "--cache-write-to=['{}']".format(cache), "--cache-read-from=['{}']".format(cache), 'examples/tests/java/org/pantsbuild/example/hello/greet', '-ldebug' ] pants_run = self.run_pants_with_workdir(args, workdir) self.assert_success(pants_run) self.assertIn('abc_Checkstyle_compile_checkstyle will write to local artifact cache', pants_run.stdout_data) pants_run = self.run_pants_with_workdir(args, workdir) self.assert_success(pants_run) self.assertIn('abc_Checkstyle_compile_checkstyle will read from local artifact cache', pants_run.stdout_data) # Make sure we are only reading from the cache and not also writing, # implying there was as a cache hit. self.assertNotIn('abc_Checkstyle_compile_checkstyle will write to local artifact cache', pants_run.stdout_data)```