https://pantsbuild.org/ logo
#general
Title
# general
l

limited-country-20626

11/22/2016, 7:52 PM
thanks for the second pass. I guess I am still a little unclear about the actual value though. To be concrete, we have
name_hashing: False
in our ini because the comment in the Pants code led us to believe it was expensive and possibly broken: https://github.com/pantsbuild/pants/commit/0b03c97748a27d26f5284ce1c88ed1b41316ede6#diff-20c24f86dff2bcf753c09453bcde7821L153 So it didn't work before and was slow. I guess it now works in 1.0.0, is there any idea of the perf hit from you all? Is the class-based dependency tracking required or does that also have a zinc option? Thanks for digging in and also for revisiting