https://pantsbuild.org/ logo
Join Slack
Powered by
specific to pants development - if you have any id...
# general
r
specific to pants development - if you have any ideas on that, feel free to jump in
w
it's specific to pants development, but also to internal plugins
r
indeed
hm, wait - does it actually affect plugins tho?
i.e. you’ve seen a confirmed case?
I would actually only expect it to affect daemon code now
w
Loose plugins: yes, definitely
They're directly on the pythonpath, right...?
(I haven't directly confirmed, but pretty sure they'll get added to sys.path in pantsd and then stay there)
r
its a mystery until evidenced I think
ultimately depends on what the side effects of global options parsing in the daemon are
but since that was externalized, it should be pretty clean
in the loose plugins case - depends when those loose plugins go onto sys.path
w
It happens before we fork.
r
right
but we’re forking from an externally launched context now
w
I mean, before we fork pantsd-runner
r
thats what I mean too
w
Not at a machine. But 95% certain
r
ah
w
Can confirm when I get back
r
yeah, confirmed
adding new goals to register.py and running 
./pants goals | grep newgoal
requires clean-all to pickup w/ 👹
w
Honestly, I think requiring a restart in that case is totally reasonable...
We'll just eventually want to do it automatically
2 Views
Open in Slack
PreviousNext
Powered by