We used to do code review on ReviewBoard. See the ...
# general
e
We used to do code review on ReviewBoard. See the 1st comment by
zundel
for an explanation of how Square use{d,s} `alias`: https://rbcommons.com/s/twitter/r/3939/
w
Thanks
w
If you have time to add some more info to the docs there, it would be appreciated!
w
Good idea. I’ll do it later this week
Are there guidelines for creating a pull request or just go for it?
w
should be an
*.md
or
*.rst
file somewhere in the repo
w
Guys I started on this today (sorry for taking the time). Just wanted to run something by you. The docs should mention both
alias
and
target
as methods for creating aliases but the latter should be used only when it’s desirable to “bundle” several targets together and perform goals on them all together. If you agree with this statement then I’ll modify the current alias docs to recommend using alias unless such a bundle is required.
👍 1
Also - I’ve seen mentioned in several places (such as the review Jon sent in this thread) that using a
target
target may cause undesired dependencies and I don’t understand how. Could you explain this please?
w
that looks right!
the "undesired dependencies" bit is just what you mentioned about "bundling" targets
w
So you’re worried that in order to alias a single project people might accidentally include other projects? The review mentioned intransitive dependencies as well in this context but I fail to understand how that’s related
w
Yes, correct.
It should not be related to intransitive dependencies.