from a `--changed` perspective we can only operate...
# generalw
witty-crayon-22786
08/29/2018, 6:41 PMfrom a
--changedf
fierce-park-88503
08/29/2018, 10:25 PMright, but this is a case where multiple targets all use the same requirements.txt as input. does any change at all to requirements.txt cause all targets depending on it to change?
w
witty-crayon-22786
08/29/2018, 10:25 PMYes.
witty-crayon-22786
08/29/2018, 10:26 PMWhat that should have said is "file/target" level
witty-crayon-22786
08/30/2018, 3:50 AMafaik though, there isn't really a good reason to use a
requirements.txtwitty-crayon-22786
08/30/2018, 3:50 AMcan just use individual requirements targets, which dodges that issue.
witty-crayon-22786
08/30/2018, 3:51 AM. @rough-minister-58256 may know better though.
f
fierce-park-88503
08/30/2018, 10:12 PMis there a nice way to get a frozen list of all transitive dependencies w/o using a requirements.txt? or just some other way of ensuring that full closure of external dep versions are frozen at a particular commit?
fierce-park-88503
08/31/2018, 2:29 PMactually… I guess it just dawned on me that having all your frozen requirements in a requirements.txt probably doesn’t actually make pants respect any of the dependencies there. like, I’m guessing pants isn’t querying pypi to take the dep graph of libs and mirror it in pants’ dep graph
w
witty-crayon-22786
08/31/2018, 6:56 PMyea. you'd actually have to create targets with dependencies to get that... ie, produce the frozen graph as BUILD targets.
f
fierce-park-88503
08/31/2018, 6:57 PMinteresting. what’s the general pants view on this? freezing deps isn’t important? just keep your pexes/other artifacts around somewhere?
w
witty-crayon-22786
08/31/2018, 6:58 PMwitty-crayon-22786
08/31/2018, 7:00 PMas that says, twitter works with the "frozen snapshot of wheels" strategy currently, since the other bit about 1) is that it lets you include whls in all cases rather than ever building something
witty-crayon-22786
08/31/2018, 7:00 PMbut i think that 2) could likely work fairly well (even without any changes to pex)
witty-crayon-22786
08/31/2018, 7:00 PMboth approaches require tooling
f
fierce-park-88503
08/31/2018, 10:30 PMoh, sorry one more thing, but about the original point of not using a requirements.txt so that the change system won’t think everything changes when you change a repo; AIUI changes to a BUILD file also just invalidate anything defined in that BUILD file (at least in 1.7 this seems to be the case), so you’d still run into this issue if you kept all your
python_requirementw
witty-crayon-22786
08/31/2018, 10:34 PMunless you did something like
3rdparty/python/${module}/BUILDwitty-crayon-22786
08/31/2018, 10:35 PM(which has the advantage of not needing to name the targets)
witty-crayon-22786
08/31/2018, 10:36 PMjust
Copy code
$ cat 3rdparty/python/s3-log-parse/BUILD
python_requirement_library(
requirements=[
python_requirement('s3-log-parse==0.1.1')
]
)