wide-energy-11069
10/26/2018, 11:38 PMwitty-crayon-22786
10/26/2018, 11:46 PMenough-analyst-54434
10/27/2018, 12:22 AMwide-energy-11069
10/27/2018, 4:53 AMwitty-crayon-22786
10/27/2018, 3:40 PMwide-energy-11069
10/28/2018, 11:11 PMpants.pex
to s3 first, and github released pex (e.g. https://github.com/pantsbuild/pants/releases/tag/release_1.11.0rc0) is then manually uploaded?
If that’s the case, does that mean I only need to add OR branch=master
to if:
stages:
- Test Pants
- name: Deploy Pants Pex
if: tag IS present AND tag =~ ^release_.*$
enough-analyst-54434
10/29/2018, 12:27 AM./build-support/bin/release.sh -p
), then directly deploys to (GitHub) releases. Master should not abuse GitHub, bintray, etc in this way.PANTS_PEX_RELEASE=stable
is untrue for master.wide-energy-11069
10/30/2018, 5:09 AMpantsbuild.pants
and its deps’ wheels are included, but none of the contrib modules. I am not sure how feasible it is to build a thicker pex in OSS, because twitter needs a pants.pex
with pantsbuild.pants
+ a subset of the contribs. (Maybe benjy can offer build-pants-pex-as-a-service :p)
I’ve reverted https://github.com/pantsbuild/pants/pull/6674 to unblock our internal release process.gorgeous-alligator-94763
10/30/2018, 6:36 AMenough-analyst-54434
10/30/2018, 6:51 AMwide-energy-11069
10/30/2018, 3:02 PMwitty-crayon-22786
10/30/2018, 3:15 PMthin
and thick
, the thick one would probably need to contain all of the contrib modulesenough-analyst-54434
10/30/2018, 3:33 PMwide-energy-11069
10/30/2018, 3:35 PMenough-analyst-54434
10/30/2018, 3:37 PM(Maybe benjy can offer build-pants-pex-as-a-service :p)I truly am dumbfounded. I thought the whole / only point of Twitter wanting to consume publically released dists / pexes was that they were the actual ones to go through CI. If you want to build an alacart pex using pre-tested wheels, you already can but that exact combo of wheels in 1 pex will not be the binary that ran ci.
release.sh -p contrib.x contrib.y
to get a multiplatfrom pex built from CI generated wheels at a given sha would be maybe a 30 delta line change and require 0 extra CI infra.release.sh -n
once locally on OSX and once in a docker image for Centos6wide-energy-11069
10/30/2018, 3:51 PMPANTS_PEX_PACKAGES
, but yeah, cli args seems betterenough-analyst-54434
10/30/2018, 3:53 PMwide-energy-11069
10/30/2018, 3:57 PMPANTS_PEX_PACKAGES
. Although rebuilding wouldn’t be possible if release.sh
is shelling out to ./pants ...
, hence the idea building everything upstream and not having to build the pex internally.enough-analyst-54434
10/30/2018, 3:57 PMgorgeous-alligator-94763
10/30/2018, 3:58 PMenough-analyst-54434
10/30/2018, 3:58 PMwide-energy-11069
10/30/2018, 3:59 PMshelling out to pants - so don’t do thatyeah, initially I took on the task to convert some of the bash to python, but it does not seem to work well, hence reverted.
enough-analyst-54434
10/30/2018, 4:00 PMgorgeous-alligator-94763
10/30/2018, 4:01 PMwide-energy-11069
10/30/2018, 4:01 PMgorgeous-alligator-94763
10/30/2018, 4:01 PMenough-analyst-54434
10/30/2018, 4:02 PMgorgeous-alligator-94763
10/30/2018, 4:04 PMenough-analyst-54434
10/30/2018, 4:05 PMwide-energy-11069
10/30/2018, 4:06 PMpip install everything
works basicallyenough-analyst-54434
10/30/2018, 4:07 PMwide-energy-11069
10/30/2018, 4:09 PMbuild-support/bin/download_binary.sh
to download the `engine.so`s?enough-analyst-54434
10/30/2018, 4:09 PMwide-energy-11069
10/30/2018, 4:11 PMenough-analyst-54434
10/30/2018, 4:11 PMwide-energy-11069
10/30/2018, 4:13 PMwitty-crayon-22786
10/30/2018, 4:13 PMenough-analyst-54434
10/30/2018, 4:14 PMwitty-crayon-22786
10/30/2018, 4:14 PMenough-analyst-54434
10/30/2018, 4:14 PMwitty-crayon-22786
10/30/2018, 4:14 PMwide-energy-11069
10/30/2018, 4:18 PMHis prior attempt didn’t try to build binaries iirc - just use Fetcherthe
run_local_pants
part is the gotcha. https://github.com/pantsbuild/pants/commit/01c807efd51ab4f98e727ab21491c18d71d462c8#diff-9ed7102b7836807dc342cc2246ec4839R438enough-analyst-54434
10/30/2018, 4:20 PMwitty-crayon-22786
10/30/2018, 4:20 PMenough-analyst-54434
10/30/2018, 4:21 PMwitty-crayon-22786
10/30/2018, 4:26 PMenough-analyst-54434
10/30/2018, 4:26 PMwitty-crayon-22786
10/30/2018, 4:35 PMenough-analyst-54434
10/30/2018, 4:37 PMwide-energy-11069
11/27/2018, 1:05 AMenough-analyst-54434
12/06/2018, 6:58 PMwitty-crayon-22786
12/06/2018, 7:00 PMenough-analyst-54434
12/06/2018, 7:00 PMwitty-crayon-22786
12/06/2018, 7:00 PMenough-analyst-54434
12/06/2018, 7:00 PMwitty-crayon-22786
12/06/2018, 7:00 PMenough-analyst-54434
12/06/2018, 7:01 PMwitty-crayon-22786
12/06/2018, 7:01 PMenough-analyst-54434
12/06/2018, 7:03 PMwitty-crayon-22786
12/06/2018, 7:04 PMenough-analyst-54434
12/06/2018, 7:04 PMwitty-crayon-22786
12/06/2018, 7:07 PMsetup
script (eg by fetching from s3) it would be easier to bisect in generalenough-analyst-54434
12/06/2018, 7:10 PMwitty-crayon-22786
12/06/2018, 7:11 PMenough-analyst-54434
12/06/2018, 7:12 PMwitty-crayon-22786
12/06/2018, 7:12 PMenough-analyst-54434
12/06/2018, 7:13 PMwitty-crayon-22786
12/06/2018, 7:13 PMenough-analyst-54434
12/06/2018, 7:14 PMwitty-crayon-22786
12/06/2018, 7:16 PMenough-analyst-54434
12/06/2018, 7:18 PMhow do you give PR contributors access to a remoting cluster?You prop up a github app. IE: you can't cheese off travis or circle, etc.
witty-crayon-22786
12/06/2018, 7:23 PMenough-analyst-54434
12/06/2018, 7:27 PMwitty-crayon-22786
12/06/2018, 7:27 PMenough-analyst-54434
12/06/2018, 7:31 PMwitty-crayon-22786
12/06/2018, 7:32 PM