https://pantsbuild.org/ logo
#general
Title
# general
r

red-balloon-89377

11/16/2018, 5:02 PM
How bad would it be to tamper with the “walk transitive dependency graph” function? In particular, I want to add optional prelude and epilogue to the traversal, functions that get called right before expanding children, and right after. Context for this is implementing Dependency Banning, and the propagation of banning constraints through dependencies, and the desire not to make it n^2
e

enough-analyst-54434

11/16/2018, 5:14 PM
Purely from an API standpoint I see no issue. This is a noop for existing consumers of the traversal and sounds otherwise reasonable.
r

red-balloon-89377

11/16/2018, 5:26 PM
Cool, thanks! I’ll do a separate PR with that.
a

average-vr-56795

11/16/2018, 5:28 PM
Yeah, sounds pretty reasonable to me 🙂
4 Views