https://pantsbuild.org/ logo
#general
Title
# general
a

aloof-angle-91616

11/28/2018, 7:37 PM
also, my travis builds have been repeatedly failing on every shard before getting to the testing, and i've tried clearing the caches and making code modifications and re-pushing several times. this error
Exception message: unexpected indent (native_compile.py, line 193)
doesn't repro locally and i cannot see any weird whitespace anywhere around that line (and i used emacs whitespace mode so i do not think it is a stray tab). can someone with more python knowledge explain why i might be seeing this error? https://travis-ci.org/pantsbuild/pants/jobs/460484253 (from https://github.com/pantsbuild/pants/pull/6800)
i have been able to repro this error now (i spent several hours), so this is no longer an issue
h

hundreds-father-404

11/28/2018, 7:58 PM
What was the issue? I didn’t see this till now, sorry!
a

aloof-angle-91616

11/28/2018, 7:58 PM
i have no clue! but i can repro it locally now
will update
...........i'm checking but i think this was git doing a wrong cherry-pick somehow
😶 1
i will admit all blame just i found the error and i can't imagine how it got there
could have been a conflict but i think not
working on it
i'm electing not to try to figure it out exactly now, but i'm not going to force push so i can try to repro this rebase error, because this concerns me greatly.
i left a comment on the ticket
it was a git rebase error as that commit worked when i added it
and travis was automatically rebasing that branch so it was occurring in travis but not locally
when i rebased it was when i was able to repro the issue and it's definitely an incorrect rebase
which just worries the heck out of me
h

hundreds-father-404

11/28/2018, 9:54 PM
Travis was rebasing? How was that happening? This sounds very difficult to debug, well done!
a

aloof-angle-91616

11/29/2018, 6:01 PM
or it was merging — the idea is that i hadn’t rebased master to pull in another PR i merged yesterday, and travis i think tries to rebase your PR before testing. since this rebase was reliably producing incorrect python, i kept seeing this error only in travis until i rebased locally to reproduce it. the bad commit is in the PR still so i was going to analyze it after i got that one green
👌 1
4 Views