also, my travis builds have been repeatedly failin...
# generala
aloof-angle-91616
11/28/2018, 7:37 PMalso, my travis builds have been repeatedly failing on every shard before getting to the testing, and i've tried clearing the caches and making code modifications and re-pushing several times. this error
Exception message: unexpected indent (native_compile.py, line 193)aloof-angle-91616
11/28/2018, 7:58 PMi have been able to repro this error now (i spent several hours), so this is no longer an issue
h
hundreds-father-404
11/28/2018, 7:58 PMWhat was the issue? I didn’t see this till now, sorry!
a
aloof-angle-91616
11/28/2018, 7:58 PMi have no clue! but i can repro it locally now
aloof-angle-91616
11/28/2018, 7:59 PMwill update
aloof-angle-91616
11/28/2018, 8:05 PM...........i'm checking but i think this was git doing a wrong cherry-pick somehow
😶 1
aloof-angle-91616
11/28/2018, 8:05 PMi will admit all blame just i found the error and i can't imagine how it got there
aloof-angle-91616
11/28/2018, 8:05 PMcould have been a conflict but i think not
aloof-angle-91616
11/28/2018, 8:05 PMworking on it
aloof-angle-91616
11/28/2018, 8:27 PMi'm electing not to try to figure it out exactly now, but i'm not going to force push so i can try to repro this rebase error, because this concerns me greatly.
aloof-angle-91616
11/28/2018, 8:27 PMi left a comment on the ticket
aloof-angle-91616
11/28/2018, 8:27 PMit was a git rebase error as that commit worked when i added it
aloof-angle-91616
11/28/2018, 8:27 PMand travis was automatically rebasing that branch so it was occurring in travis but not locally
aloof-angle-91616
11/28/2018, 8:27 PMwhen i rebased it was when i was able to repro the issue and it's definitely an incorrect rebase
aloof-angle-91616
11/28/2018, 8:27 PMwhich just worries the heck out of me
h
hundreds-father-404
11/28/2018, 9:54 PMTravis was rebasing? How was that happening? This sounds very difficult to debug, well done!
a
aloof-angle-91616
11/29/2018, 6:01 PMor it was merging — the idea is that i hadn’t rebased master to pull in another PR i merged yesterday, and travis i think tries to rebase your PR before testing. since this rebase was reliably producing incorrect python, i kept seeing this error only in travis until i rebased locally to reproduce it. the bad commit is in the PR still so i was going to analyze it after i got that one green
👌 1
4 Views