https://pantsbuild.org/ logo
Powered by
n

nutritious-monkey-78516

12/06/2018, 5:44 PM
Is there a trick? or something I am missing?
e

enough-analyst-54434

12/06/2018, 5:47 PM
What do you mean by namespace/pathing - are you referring to python namespace packages? You'll need to provide a bit more detail of the errors you encountered before coming to the solution of one BUILD file to make this more clear.
n

nutritious-monkey-78516

12/06/2018, 5:54 PM
So for example, if I have a file that I want to import into a python file like 
from foo.bar import helloworld
I find myself having to have a 
BUILD
file at the parent of 
/foo
instead of 
/foo/bar/BUILD
In order to keep that pathing.
e

enough-analyst-54434

12/06/2018, 5:57 PM
Aha - @brief-engineer-67497's line of questioning is related. Pants expects code to be housed under "source roots"; ie 
src/python
. When it can't auto-guess your source roots, it assumes the source root is where the BUILD file lives. I'm guessing your repo layout is:
Copy code
foo/
  __init__.py
  bar/
  __init__.py
setup.py
The source roots can be configured in pants.ini but I'm not sure off the top of my head if there is a way to say the root of the repo is the source root.
Just a sec - checking on this...
n

nutritious-monkey-78516

12/06/2018, 5:59 PM
Thanks I know its a config issue
Do you know where in the documentation its saying this?
e

enough-analyst-54434

12/06/2018, 6:01 PM
There is mention of source roots in the setup docs, but it's not super helpful for your case: https://www.pantsbuild.org/setup_repo.html
b

brief-engineer-67497

12/06/2018, 6:02 PM
hmm so the "root" of code source and resources are somewhat bind ?
e

enough-analyst-54434

12/06/2018, 6:02 PM
no
You can have an arbitrary number of source roots
When packaging code, pants follows dependency links in BUILD files and subtracts off source roots from paths to make bundles - jars, wheels, etc
b

brief-engineer-67497

12/06/2018, 6:04 PM
ok so given
Copy code
register('--source-root-patterns', metavar='<list>', type=list, fingerprint=True,
             default=cls._DEFAULT_SOURCE_ROOT_PATTERNS, advanced=True,
             help=pattern_help_fmt.format('source'))
how do I now what is the scope in pants.ini ?
is it like
Copy code
[source]
rout-patterns: [<val>]
?
e

enough-analyst-54434

12/06/2018, 6:06 PM
It's non-trivial. If you drop the leading 
--
and convert 
-
to 
_
, you can always:
Copy code
$ ./pants options | grep source_root_patterns
source.source_root_patterns = ['src/*', 'src/main/*'] (from HARDCODED)
So it's:
Copy code
[source]
source_root_patterns: [<vals>]
b

brief-engineer-67497

12/06/2018, 6:10 PM
hmm nice trick ! thank you very much
n

nutritious-monkey-78516

12/06/2018, 6:10 PM
Oh okay I’ll test that out later today
thanks
e

enough-analyst-54434

12/06/2018, 6:11 PM
Test out what? I'm not sure how to solve your problem @nutritious-monkey-78516
b

brief-engineer-67497

12/06/2018, 6:12 PM
I'm really surprise to learn that the BUILD file do not decied of what is the root of sources
e

enough-analyst-54434

12/06/2018, 6:13 PM
Stepping back, on of the main thrusts of pants from day one was to be able to take a large source tree and divide it up into fine grained targets. In this case you have 1 source tree with many (hundreds or thousands) of build files down in the tree. In that case the BUILD files do not live in the source root - it's seperate up higher, at - say - src/java.
n

nutritious-monkey-78516

12/06/2018, 6:13 PM
Trying out the source_roots thing in my 
pants.ini
b

brief-engineer-67497

12/06/2018, 6:14 PM
and It explain why intellij is messed up for "play" project that somewhat decided that sources should be under an 
app
directory
n

nutritious-monkey-78516

12/06/2018, 6:14 PM
I think that’s what I am trying to get to.
e

enough-analyst-54434

12/06/2018, 6:15 PM
OK. I don't follow the details - but Intellij has the exact same concept. You mark directories source roots, test roots, resource roots, etc.
n

nutritious-monkey-78516

12/06/2018, 6:16 PM
Yeah, I think if I adjsut the pants.ini source_root I can import everything correctly instead of having one bloated 
BUILD
file that is pulling everything in.
e

enough-analyst-54434

12/06/2018, 6:30 PM
@nutritious-monkey-78516 the magic is:
Copy code
[source]
source_roots: {
    '': ['python']
  }
n

nutritious-monkey-78516

12/06/2018, 6:31 PM
Okay thanks I’ll play around with that tonight
Is that anywhere in the documentation?
e

enough-analyst-54434

12/06/2018, 6:31 PM
No
I'm of two minds about this. Clearly it should be documented as things stand since your layout is the typical python project layout sans-pants. Better would be for pants to understand this layout out of the box. I'll file an issue either way here shortly.
n

nutritious-monkey-78516

12/10/2018, 10:17 PM
I just tried this into my pants.ini and its giving me errors.
Actually I think it has to do something with the parsing of the string. I have to put it into one line.
e

enough-analyst-54434

12/10/2018, 10:59 PM
The spacing in my example is significant to be sure. all continuation lines must be indented.
n

nutritious-monkey-78516

12/10/2018, 11:17 PM
Yeah, I’ll try out with the spacing, but I just made everything one line, and it worked.
Okay, I got it to work. I think, my stuff was doing the indents at two-spaces
4 Views
Powered by