I'm trying to clear duplicate warnings from a `jvm...
# general
m
I'm trying to clear duplicate warnings from a
jvm_binary
target. I'm addressing some by using
Duplicate.CONCAT_TEXT
or
Skip()
, which works when looking inside the jar, but the "dup" task is still outputting them to be a duplicate. Looking at the task code it doesn't seem to take any JarRules into account. Is there a proper way of telling pants that these have been addressed for a specific target (I don't want to globally ignore specific things as they might not be addressed in new/other targets)? Examples of what I'm looking at which I think would be pretty common: *
META-INF/INDEX.LIST
and
META-INF/io.netty.versions.properties
from Netty *
reference.conf
from Akka
w
thanks for looking at that... a patch would be very welcome!
m
Ah, so this is not me doing things wrong with my dependencies? 🙂
w
it sounds like you know better than i do, since you've looked at that code
😆 1
m
Ok, I'll definitely open a PR if I find the time to look that deep into it
w
thanks!
m
Took a stab at it, this seems to work for my codebase: https://github.com/pantsbuild/pants/pull/7113