fancy-queen-20734
02/04/2019, 10:27 PMaloof-angle-91616
02/04/2019, 10:40 PMsources
?fancy-queen-20734
02/04/2019, 10:41 PMaloof-angle-91616
02/04/2019, 10:43 PMfancy-queen-20734
02/04/2019, 10:43 PMaloof-angle-91616
02/04/2019, 10:45 PMfancy-queen-20734
02/04/2019, 10:46 PMaloof-angle-91616
02/04/2019, 10:47 PMfancy-queen-20734
02/04/2019, 10:48 PMsrc/java/org/foo/a
src/scala/org/foo/a
aloof-angle-91616
02/04/2019, 10:49 PMfancy-queen-20734
02/04/2019, 10:49 PMsrc/java/com.foo.bar/
aloof-angle-91616
02/04/2019, 10:51 PMfiles
target since it is real code and not a resource and that feels pretty confusingfancy-queen-20734
02/04/2019, 10:51 PMaloof-angle-91616
02/04/2019, 10:52 PMfancy-queen-20734
02/04/2019, 10:52 PMaloof-angle-91616
02/04/2019, 10:52 PMfancy-queen-20734
02/04/2019, 10:52 PMaloof-angle-91616
02/04/2019, 10:56 PMfancy-queen-20734
02/04/2019, 10:57 PMaloof-angle-91616
02/04/2019, 10:58 PMfiles
fancy-queen-20734
02/04/2019, 11:00 PMsrc/something-for-both-java-and-scala/....
files
in that it’s a set of files that is at rest unless another target says its going to use it for somethingaloof-angle-91616
02/04/2019, 11:03 PMwitty-crayon-22786
02/04/2019, 11:04 PMaloof-angle-91616
02/04/2019, 11:04 PMfancy-queen-20734
02/04/2019, 11:05 PMi expect that v2 will change this entirely, so diving in too deep right now isn’t worthwhile^^ is another reason for using
files
and making the smallest semantic change possible that eliminates the issues. It also could simplify some of the things we’re trying to convert to v2witty-crayon-22786
02/04/2019, 11:06 PMfancy-queen-20734
02/04/2019, 11:07 PMaloof-angle-91616
02/04/2019, 11:16 PMcom/twitter/...
and drops the classfiles in there but it does that regardless of where the input file is located, depending just on the declared package com.twitter;
fancy-queen-20734
02/04/2019, 11:23 PMaloof-angle-91616
02/04/2019, 11:24 PMfancy-queen-20734
02/04/2019, 11:25 PMaloof-angle-91616
02/04/2019, 11:26 PMpackage
declaration, not from the file pathfancy-queen-20734
02/04/2019, 11:26 PMaloof-angle-91616
02/04/2019, 11:28 PMfancy-queen-20734
02/04/2019, 11:29 PMaloof-angle-91616
02/04/2019, 11:30 PMfancy-queen-20734
02/04/2019, 11:30 PMaloof-angle-91616
02/04/2019, 11:33 PMsources_by_source_roots()
method which returns an OrderedDict
and deprecating sources_relative_to_source_root()
sounds like a startfancy-queen-20734
02/04/2019, 11:34 PMaloof-angle-91616
02/04/2019, 11:35 PMjava_sources
to just be sources
fancy-queen-20734
02/04/2019, 11:36 PMaloof-angle-91616
02/04/2019, 11:38 PMsources
or java_sources
without having the current invalidation issuefancy-queen-20734
02/04/2019, 11:39 PMaloof-angle-91616
02/04/2019, 11:39 PMfancy-queen-20734
02/04/2019, 11:39 PMjava_sources
featurealoof-angle-91616
02/04/2019, 11:42 PMjava_sources
in the current incarnation, deferred sources seems like a very appropriate analogy or at least i think that whenever i see a target kwarg that accepts another target specfancy-queen-20734
02/04/2019, 11:43 PMsources
because it’s points to targets and sources
is globsaloof-angle-91616
02/04/2019, 11:45 PMjava_sources
was referring to targetsdeferred_sources
might work here? looking at how we currently handle java_sources
unpacked_jars()
to wrap java_library()
targets (interdependent_java()
?) for use in `scala_library()`s in either the java_sources
kwarg or a new one (and then make a tiny task that populates deferred_sources
), that also gives us the possible extra benefit of being able to only depend on specific files within the java_library()
target with include_patterns
. that may not be useful (so we could just make it always include **/*
), but it would be safe from the current bug since only those files would be visible to the scala target.fancy-queen-20734
02/05/2019, 7:05 PMaloof-angle-91616
02/05/2019, 7:05 PMremote_sources()
and unpacked_jars()
is exactly this, the only difference is that we wouldn't need to unpack any jars since `java_library()`s are just sourcesfancy-queen-20734
02/05/2019, 7:06 PMaloof-angle-91616
02/05/2019, 7:06 PMfancy-queen-20734
02/05/2019, 7:07 PMaloof-angle-91616
02/05/2019, 7:07 PMfiles
might be fine then to make that crystal clear, i would still prefer even an alias for files
like java_files
but i think the proposal sounds appropriate because it is probably important to denote that these aren't real targets quote unquotefancy-queen-20734
02/05/2019, 7:09 PMaloof-angle-91616
02/05/2019, 7:09 PM