https://pantsbuild.org/ logo
#general
Title
# general
l

little-salesclerk-62826

03/18/2019, 7:20 PM
Hi again! Could you please take a look to my PR https://github.com/pantsbuild/pants/pull/7342 Thank you!
h

hundreds-father-404

03/18/2019, 7:23 PM
I don’t know Rust well enough to review. Looks like good code though! One thought, in PR description briefly describe what a span refers to
l

little-salesclerk-62826

03/19/2019, 12:44 PM
I updated my PR @average-vr-56795
2 Views