Small question: What is the best way to write an i...
# generalr
red-balloon-89377
03/20/2019, 4:32 PMSmall question: What is the best way to write an integration test that “runs pants, modifies a file (that exists in the buildroot), runs pants again”? Currently my approach is to create a
temporary_workdir():a
average-vr-56795
03/20/2019, 4:38 PMDorothy and I totally added a thing for this…
average-vr-56795
03/20/2019, 4:39 PMPantsRunIntegrationTest.temporary_file_contentaverage-vr-56795
03/20/2019, 4:40 PM Copy code
with self.temporary_file_content(path, content, binary_mode=False):
pants_run = self.run_pants(command=command)r
red-balloon-89377
03/20/2019, 4:40 PMAh
red-balloon-89377
03/20/2019, 4:40 PMThat is very cool!
a
average-vr-56795
03/20/2019, 4:41 PMOh, that one deletes the file after the run, instead of restoring its original value… I’m sure we had one for that too…
r
red-balloon-89377
03/20/2019, 4:41 PMWait, but I want to edit a file that exists already
a
average-vr-56795
03/20/2019, 4:42 PMcontextutil.with_overwritten_file_contentaverage-vr-56795
03/20/2019, 4:43 PMBut apparently left the test method to do the writing of the new value, rather than the decorator… Could be nice to modify it to have a
temporary_contentsr
red-balloon-89377
03/20/2019, 4:44 PMOh cool 🙂 Any idea why this is not in
PantsIntegrationTestBasea
average-vr-56795
03/20/2019, 4:44 PMFeel free to move it 🙂
r
red-balloon-89377
03/20/2019, 4:44 PMCool, that sounds like a separate PR 🙂
a
average-vr-56795
03/20/2019, 4:44 PMTotally
r
red-balloon-89377
03/20/2019, 4:45 PMCool, I may have time to do that today
red-balloon-89377
03/20/2019, 4:47 PMAlso, thanks!