<@UH6670BHD> We've done this internally, I don't r...
# generalh
happy-kitchen-89482
03/25/2019, 3:46 PM@loud-guitar-4381 We've done this internally, I don't remember the details, and I'm in the middle of a couple of things now, but ping me in a couple of hours and I'll look up how I did it...
👍 1
a
aloof-angle-91616
03/25/2019, 3:47 PMwhat we did was to run a pants subprocess to build jvm binaries then stitched them into the build graph
aloof-angle-91616
03/25/2019, 3:47 PMinterested in however you ended up doing it too
h
happy-kitchen-89482
03/25/2019, 3:47 PMWe did something less hacky than that IIRC
🔥 2
a
aloof-angle-91616
03/25/2019, 3:48 PMooooh, now i’m very interested
l
loud-guitar-4381
03/25/2019, 9:02 PM@happy-kitchen-89482 Hi. just wanted to see if you got a chance to look up the mechanism for doing this. thanks in advance.
h
happy-kitchen-89482
03/26/2019, 1:33 AMNot yet, sorry. Crazy day. Remind me tomorrow morning?
l
loud-guitar-4381
03/26/2019, 1:34 AMnp. sure
loud-guitar-4381
03/26/2019, 2:12 PMHi @happy-kitchen-89482 just a friendly reminder on the above ^. thanks in advance.
h
happy-kitchen-89482
03/26/2019, 9:01 PM@aloof-angle-91616 should weigh in on whether this makes sense, but as far as I can tell we called
self.runjava()happy-kitchen-89482
03/26/2019, 9:02 PMWhich we find by:
happy-kitchen-89482
03/26/2019, 9:03 PM Copy code
indexer_main_tgt = self.context.build_graph.get_target_from_spec('src/java/com/toolchain/asm/indexer')
classpath_products = self.context.products.get_data('runtime_classpath')
classpath = ClasspathUtil.classpath(indexer_main_tgt.closure(), classpath_products)happy-kitchen-89482
03/26/2019, 9:03 PMAnd we have a custom target type that injects a dep on the indexer, so that if the indexer gets modified the target is invalidated
a
aloof-angle-91616
03/26/2019, 10:32 PMlmao
aloof-angle-91616
03/26/2019, 10:33 PMyeah that's a lot better
aloof-angle-91616
03/26/2019, 10:34 PMi honestly cannot see an issue with that approach at all
w
witty-crayon-22786
03/26/2019, 10:37 PMthe runtime classpath won't exist in, say, the gen phase
witty-crayon-22786
03/26/2019, 10:37 PMso that will work for tools that run after the compiler, but not before
a
aloof-angle-91616
03/26/2019, 10:37 PMv1 strikes again
w
witty-crayon-22786
03/26/2019, 11:07 PMi don't love our solution, but we should probably open source it.
l
loud-guitar-4381
03/27/2019, 2:28 AMI don’t understand the solution and looking for some clarification
loud-guitar-4381
03/27/2019, 2:29 AMI guess indexer is your jvm tool and located src/java/com/toolchain/asm/indexer
loud-guitar-4381
03/27/2019, 2:30 AMfor example lets say I am running a task on a particular target for. eg: some_target:scala which doesn’t depend on indexer. how will the context.build_graph contain index target.
loud-guitar-4381
03/27/2019, 2:34 AMnvm, I understand it now. custom target type that injects a dep on the indexer
loud-guitar-4381
03/27/2019, 2:35 AMThanks a lot @happy-kitchen-89482 for your approach.
loud-guitar-4381
03/27/2019, 2:36 AMnot a great solution for me. I need to inject this jvm tool in every target in the codebase. This jvm tools contains custom scalafix rules for enforcing linting.
h
happy-kitchen-89482
03/27/2019, 6:00 PMYes, indexer is our custom tool
happy-kitchen-89482
03/27/2019, 6:01 PMYou can inject the jvm tool on every, say,
java_libraryregister.pyjava_library