so you might check whether you have multiple provides clause Pants #general

Join Slack

so you might check whether you have multiple provi...

# general

witty-crayon-22786

03/28/2019, 4:12 PM

so you might check whether you have multiple provides clauses in the graph you are publishing

fierce-park-88503

03/28/2019, 5:12 PM

I thought of that, but a) no, this is the only

provides

clause in the whole repo afaik, b) it seems like in that case the error would be

AmbiguousOwnerError

, instead of

NoOwnerError

witty-crayon-22786

03/28/2019, 5:13 PM

does

./pants paths thing/I/want/a/wheel/for an/internal/python_library/target/I/depend:on

show you a path between them?

fierce-park-88503

03/28/2019, 5:16 PM

yup:

[thing/I/want/a/wheel/for , an/internal/python_library/target/I/depend:on]

it’s a direct dep

fierce-park-88503

03/28/2019, 5:16 PM

it would have to, right? otherwise why would pants be looking at

an/internal/python_library/target/I/depend:on

when trying to run setup-py on

thing/I/want/a/wheel/for

witty-crayon-22786

03/28/2019, 5:17 PM

if it were an alias

fierce-park-88503

03/28/2019, 5:17 PM

ah, ok

witty-crayon-22786

03/28/2019, 5:17 PM

you've said it isn't, but just confirming.

fierce-park-88503

03/28/2019, 5:18 PM

I tried pdb-ing through the pants code, and it seemed like actually maybe I need

thing/I/want/a/wheel/for

to be a parent in the directory/package hierarchy of

an/internal/python_library/target/I/depend:on

. like the latter would actually have to be

thing/I/want/a/wheel/for/an/internal/python_library/target/I/depend:on

. but I’m not sure I understand exactly what’s going on

witty-crayon-22786

03/28/2019, 5:19 PM

would be good to file an issue about this, but you'll need to give a pretty detailed overview of the graph in order for anyone to get a repro.

witty-crayon-22786

03/28/2019, 5:19 PM

mm, yea, could be.

witty-crayon-22786

03/28/2019, 5:20 PM

yea, i forgot about that bit.

fierce-park-88503

03/28/2019, 5:20 PM

ok, I’ll poke around with that last hunch and if not I’ll try and get a minimal repro and file an issue

fierce-park-88503

03/29/2019, 9:12 PM

sorry to revive this — so, I made a top-level wheel package that includes my other library target in its

dependencies

. now the wheel builds, but none of the code ends up actually making it into the wheel? like the wheel just consists of a single

__init__.py

file

fierce-park-88503

03/29/2019, 9:12 PM

in general, the

setup-py

goal should include code from transitive deps, not just the direct dep of the python_library that’s being `setup-py`d, right?

witty-crayon-22786

03/29/2019, 9:54 PM

yes. would suggest filing that ticket with an explanation of the layout at this point

3 Views

Open in Slack

Previous Next