https://pantsbuild.org/ logo
Powered by
f

fierce-park-88503

04/06/2019, 5:08 PM
I’m not even trying to co-mingle tests and src right now, just moving src/python/my_org to ROOT/my_org and moving tests/python/my_org_test to ROOT/my_org_test
a

aloof-angle-91616

04/06/2019, 10:49 PM
i don't know if i can see any blockers to just doing that -- are you finding issues when you try? you should be able to move things like you describe and have it just work
f

fierce-park-88503

04/07/2019, 1:27 AM
one issue is that you mess up any in-flight changes. which is kind of annoying but not the end of the world
n

nutritious-monkey-78516

04/07/2019, 5:28 AM
Have you tried to use source_roots?
f

fierce-park-88503

04/08/2019, 2:49 AM
Not sure what you mean. 
src/python
used to be a source root, trying to move away from that and just have the root of the repo be the source root
@aloof-angle-91616 I definitely annoyed a few people w/ merge conflicts, lol.
a

aloof-angle-91616

04/08/2019, 7:22 PM
hey sorry
moving code will do that i guess
f

fierce-park-88503

04/08/2019, 7:24 PM
it’s not that bad though, the merge fix is just like, merge up to right before the change as normal, merge the move, resolve the merge by just blindly moving/renaming.
a

aloof-angle-91616

04/08/2019, 7:24 PM
it might be possible to 
cp -r
the previous directory to the current one
that's more developed than what i had thought, great
are the conflicts resolved now?
f

fierce-park-88503

04/08/2019, 7:25 PM
not sure, have to catch up with the folks who had the in-flight changes
they’re temporarily stopped yelling at me though, so 👍
👍 1
a

aloof-angle-91616

04/08/2019, 7:26 PM
i would love to pitch in if people start yelling again
f

fierce-park-88503

04/08/2019, 7:27 PM
we work at different companies so that might be difficult 😛
appreciate the offer though
a

aloof-angle-91616

04/08/2019, 7:27 PM
just in terms of pants help!
f

fierce-park-88503

04/08/2019, 7:27 PM
ah ok
a

aloof-angle-91616

04/08/2019, 7:27 PM
or git maybe too, yelling is no fun
f

fierce-park-88503

04/08/2019, 7:27 PM
“yelling” was strong, people weren’t too upset, just mildly grumbling
a

aloof-angle-91616

04/08/2019, 7:28 PM
lower on the yelling axis
f

fierce-park-88503

04/08/2019, 7:28 PM
I think git does have some level of rename detection that should make this easier, but I don’t think it always works too well, and seems to really have trouble with large moves
moving it piece by piece in a few changes might have helped
a

aloof-angle-91616

04/08/2019, 8:07 PM
there are some options you can configure for change/rename detection, we use them in our pre-commit hook
not sure if it would help here though
5 Views
Powered by