pylintrc.txt

we would probably be interested in a pull request if you'd like to turn this into one!

Sure. However, it needs to be configured with some kind of CI server. Here at RapidSOS, we use codacy to enforce Pylint rules when engineers try to merge a PR. Codacy uses this pylintrc file and enforce the rule at merging. That prevents bad code from checking in.

we have lint on our CI, we have a pretty intense set of linting that we've developed: https://github.com/pantsbuild/pants/tree/master/contrib/python/src/python/pants/contrib/python/checks/checker. we might be interested in more incremental changes, but it might be difficult to accept a single lint change at once which affects a large amount of the repo

I've been expeirmenting w/ using

black

or

yapf

for my own codebases, what was the thought rolling your own linting vs one of those?

😄

we don't actually roll our own, we extend pycodestyle i am p sure

ahhh gotcha

the ones we've developed are for things we just want to lint ourselves

I would love to use

black

. The main issue is

black

uses 4 spaces, and we need to allow 2 space indentation. We could use https://github.com/desbma/black-2spaces (fork) to get around this potentially, or maybe

yapf

i have very negative feelings about a linter that requires 4 spaces, i really like how hackable our current setup is and how easy it is to develop new lints

Black is an opinionated auto- formatter, like Prettier. From what I can tell,

yapf

is more configurable