https://pantsbuild.org/ logo
#general
Title
# general
g

gorgeous-alligator-94763

04/25/2019, 6:01 PM
Is there a reason why each integration test has a really aggressive 60 second timeout?
a

aloof-angle-91616

04/25/2019, 6:03 PM
do you mean by default? i think that's the default for
python_tests()
and we don't try to automatically change it when the target has
tags={'integration'}
, although that wouldn't be a bad idea, it's just hard to know what the right default should be. you can add
timeout = 240
or whatever makes sense
g

gorgeous-alligator-94763

04/25/2019, 6:04 PM
i did change the default just so I can get past all the tests timing out, but it seems kind of aggressive for an integration test
a

aloof-angle-91616

04/25/2019, 6:05 PM
yes
this is probably worth an issue too
it’s just that the timeout is currently determined by the test target and not the test itself and we don’t have separate test target types for integration tests
so not sure where we would put the higher default since we probably don’t want to make unit tests default to running too long i think
i agree with your premise
g

gorgeous-alligator-94763

04/25/2019, 6:08 PM
i suspect this will be less of a problem as time goes on, so its not a big deal, just a little frustrating when my tests were timing out
a

aloof-angle-91616

04/25/2019, 6:40 PM
that makes sense
a

average-vr-56795

04/25/2019, 8:22 PM
The main problem is that we only actually run tests on CI both sharded (which means we don't run full targets) and together in clumps (which sums the timeouts of each target). So all our timeout numbers are meaningless.
a

aloof-angle-91616

04/25/2019, 8:23 PM
sounds like an excuse to scorch some earth