If I print the result of

handler.parsed_request()

from the threads, I get:

# The first thread
ENv is {'PANTSD_REQUEST_TIMEOUT_LIMIT': '-1'}
# The second thread
ENv is {}

is there a reason it's not like

self.mock_handler_inst.parsed_request.return_value = (None, None, [], fake_environment)

?

Yes

mock is confusing to me and i tend to cargo cult things that work elsewhere in the repo

Still doesn’t work 😞

what is

self.mock_handler_inst

?

An instance of

PailgunHandler

this is super confusing, i love it

It is! https://github.com/pantsbuild/pants/pull/7781/files

thanks!

pushed

will spend a moment checking it out

Thanks! Don’t spend too much though 🙂

me? never

Do you also get

Request <Mock id='140712395185904'> errored with 'PANTSD_REQUEST_TIMEOUT_LIMIT'

?

omg i'm sorry

I have to leave 😞 I’ll read up on Mock’s documentation tomorrow. I’m also less and less suprised that we don’t have as many unit tests as we want. This framework is hard!

it doesn't appear there's any reason we're using

.pop()

. this diff caused it to pass for me:

diff --git a/src/python/pants/pantsd/pailgun_server.py b/src/python/pants/pantsd/pailgun_server.py
index fd0c522..f768f22 100644
--- a/src/python/pants/pantsd/pailgun_server.py
+++ b/src/python/pants/pantsd/pailgun_server.py
@@ -209,7 +209,7 @@ class PailgunServer(ThreadingMixIn, TCPServer):
     """
     # TODO add `did_poll` to pantsd metrics

-    timeout = float(environment.pop('PANTSD_REQUEST_TIMEOUT_LIMIT'))
+    timeout = float(environment['PANTSD_REQUEST_TIMEOUT_LIMIT'])

     @contextmanager
     def yield_and_release(time_waited):

Omg

np!!!