hundreds-father-404
10/13/2019, 2:52 AMpantsbuild.pants.testinfra
wheel that we release to PyPI because we’re moving the code to src/python/pants
instead of tests/python/pants_test
. Thoughts or suggestions?
Possible candidates:
pantsbuild.pants.tests
pantsbuild.pants.testutils
pantsbuild.pants.testsupport
pantsbuild.pants.testing
average-vr-56795
10/14/2019, 9:28 AMhundreds-father-404
10/14/2019, 1:22 PMaverage-vr-56795
10/14/2019, 1:23 PMtests/
?hundreds-father-404
10/14/2019, 1:37 PMsrc/
wheel with a deprecation cycle with a warning to migrate. So, you can still use from pants_tests.base_tests
but you should use from pants.testutils.base_test
srcs
wheelaverage-vr-56795
10/14/2019, 1:40 PMhundreds-father-404
10/14/2019, 1:47 PMpantsbuild.pants.testutils
implies src/python/pants/testutils
I simply don’t know what to call the thingaverage-vr-56795
10/14/2019, 1:47 PMhundreds-father-404
10/14/2019, 1:50 PMWe could just keep it being one wheel, and have both symbols be available in it for two releases?That’s what I really wanted to do, but it’s impossible :/ see my comment about “owned” files. I spent a lot of time wrestling with it to try to get one wheel to work
average-vr-56795
10/14/2019, 1:58 PMhundreds-father-404
10/14/2019, 2:01 PMaverage-vr-56795
10/14/2019, 2:01 PMhundreds-father-404
10/14/2019, 2:05 PMenough-analyst-54434
10/14/2019, 2:15 PMaverage-vr-56795
10/14/2019, 2:18 PMpants_test
top-level package was a mistake (and the logic there is in fact codifying that it was a mistake)?enough-analyst-54434
10/14/2019, 2:20 PMself.dependency_calculator
.average-vr-56795
10/14/2019, 2:25 PMallowed_extra_roots
which we’d recommend people only used for migration?enough-analyst-54434
10/14/2019, 2:27 PMallowed_extra_roots
we scold them. Perhaps we should just let them be and allowed_extra_roots. Someone else can make that call.average-vr-56795
10/14/2019, 2:29 PMhundreds-father-404
10/14/2019, 2:35 PMaverage-vr-56795
10/14/2019, 2:36 PMenough-analyst-54434
10/14/2019, 2:40 PMfresh-architect-74417
10/14/2019, 9:01 PMunittesting
, then put all testing libraries there.tests/
directory with the unittests in them?hundreds-father-404
10/15/2019, 12:38 AMDoes that mean all module directories will have `tests/`directory with the unittests in them?For the internal Pants repo, we’re moving in the direction of having all Pants tests live at the same level as src code in the
src
folder. So, we would have src/python/pants/util/strutil.py
and src/python/pants/util/test_strutil.py
This discussion is about where the test util code for Pants should live. Right now, for example, it’s tests/python/pants_test/test_base.py
and we want to move it to src/python/pants/testutils/test_base.py
The tricky part is that we release our test utils as a wheel for Pants plugin authors to use in their own testing. We need to (for two release cycles) still release the old stuff.