https://pantsbuild.org/ logo
e

early-needle-54791

12/02/2019, 6:28 PM
I’m going to make a PR which changes our zinc wrapper, and therefore needs a new version of zinc to be published. Should I post the PR without publishing the new zinc version to maven in case there are changes requested? It feels a bit like a chicken and egg situation, advice appreciated.
w

witty-crayon-22786

12/02/2019, 6:51 PM
@early-needle-54791: yea, unfortunately: that's what is needed
basically, two PRs, the latter of which won't work until the first is landed and published.
e

early-needle-54791

12/02/2019, 6:54 PM
Meaning split the work into two PRs?
or have one that bumps the version and all the changes in the other?
by split the work I mean putting all the zinc wrapper related code into one PR then bump the version and use the new zinc wrapper in the other.
w

witty-crayon-22786

12/02/2019, 6:56 PM
or have one that bumps the version and all the changes in the other?
this^
👍 1
e

early-needle-54791

12/02/2019, 6:57 PM
is publishing zinc part of the CI pipeline?
w

witty-crayon-22786

12/02/2019, 6:58 PM
it's manual, unfortunately. can ping me/Benjy/John once the PR lands
e

early-needle-54791

12/02/2019, 6:59 PM
K.
w

witty-crayon-22786

12/02/2019, 6:59 PM
... we should likely have more folks with the keys. i think that we got Daniel set up at some point as well?
5 Views