I’m going to make a PR which changes our zinc wrap...
# generale
early-needle-54791
12/02/2019, 6:28 PMI’m going to make a PR which changes our zinc wrapper, and therefore needs a new version of zinc to be published. Should I post the PR without publishing the new zinc version to maven in case there are changes requested? It feels a bit like a chicken and egg situation, advice appreciated.
w
witty-crayon-22786
12/02/2019, 6:51 PM@early-needle-54791: yea, unfortunately: that's what is needed
witty-crayon-22786
12/02/2019, 6:52 PMbasically, two PRs, the latter of which won't work until the first is landed and published.
e
early-needle-54791
12/02/2019, 6:54 PMMeaning split the work into two PRs?
early-needle-54791
12/02/2019, 6:54 PMor have one that bumps the version and all the changes in the other?
early-needle-54791
12/02/2019, 6:55 PMby split the work I mean putting all the zinc wrapper related code into one PR then bump the version and use the new zinc wrapper in the other.
w
witty-crayon-22786
12/02/2019, 6:56 PMor have one that bumps the version and all the changes in the other?
witty-crayon-22786
12/02/2019, 6:56 PMthis^
👍 1
e
early-needle-54791
12/02/2019, 6:57 PMis publishing zinc part of the CI pipeline?
w
witty-crayon-22786
12/02/2019, 6:58 PMit's manual, unfortunately. can ping me/Benjy/John once the PR lands
witty-crayon-22786
12/02/2019, 6:59 PMdescribed here: https://www.pantsbuild.org/release_jvm.html
e
early-needle-54791
12/02/2019, 6:59 PMK.
w
witty-crayon-22786
12/02/2019, 6:59 PM... we should likely have more folks with the keys. i think that we got Daniel set up at some point as well?
5 Views