I’m doing some work around making it easier to have targets that want different runtime platforms. This is some refactoring / consolidation work that moves towards making those changes easier. https://github.com/pantsbuild/pants/pull/8938

If you have a little extra time, consider adding type hints to that code for extra validation that this works properly and better readability. Have you used type hints and MyPy before? It could be a can of worms though because we don’t have many type hints for V1 and aren’t planning on investing the time in that. When you add new type hints to untyped code, you often find issues (usually that MyPy needs more information).

I have not yet

Thanks @fancy-queen-20734!

should I just look around for examples to crib from elsewhere in the repo?

Yes that works well 🙂 https://mypy.readthedocs.io/en/stable/cheat_sheet_py3.html is a great cheat sheet also

@hundreds-father-404 I think it’d be clearer if the type annotations were added as a separate change. I have to move some things around for it to work

Okay sounds good! Don’t worry about adding them in general, also. Generally, we expect V2 code to be typed, but there’s no expectation for V1

Does V2 use subsystems as they are currently defined, or will they be redefined using rules as they are pulled in?

Does V2 use subsystems as they are currently defined, or will they be redefined using rules as they are pulled in?

V2 uses

Subsystem

normally, although declares its depedency through a

subsystem_rule

, rather than through

global_subsystems

in a

register.py

. For example: https://github.com/pantsbuild/pants/blob/master/src/python/pants/rules/core/strip_source_root.py#L62

I see. I think nothing uses the subsystem I’m modifying from V2 right now, though I expect that to change in the future. It looks like apart from having to move around declarations to make the typer happy, adding type hints should be straightforward though

thanks! looking.

@witty-crayon-22786 I responded to your feedback on the patch

@fancy-queen-20734: looks good. i think i agree that strictness could/should be a property of the platform.

sure

the general gist of the direction we're headed in is that we should be much more Subsystem centric than Task centric, if possible.

This is because we don’t have tasks in V2. Moving options to subsystems helps a lot for allowing us to migrate things easily to V2

makes sense