https://pantsbuild.org/ logo
#general
Title
# general
f

fancy-queen-20734

02/18/2020, 11:15 PM
a

aloof-angle-91616

02/18/2020, 11:18 PM
on a separate but related note, do you think jvm options for any tool (junit and other) and/or the platform/distribution selection might be something that's worth adding a
CompilerOptionSetMixin
to?
enables setting up a dictionary in pants.ini which allows targets to selectively turn on and off sets of command-line options in a hygeinic way
+ i can offer to implement this entirely if it would help you
it would be a single small PR
f

fancy-queen-20734

02/18/2020, 11:21 PM
hm. that does seem useful. I’d need to think about it a little further.
a

aloof-angle-91616

02/18/2020, 11:22 PM
yes!
just a thought
f

fancy-queen-20734

02/18/2020, 11:22 PM
I feel like there’s a potential for a more consistent, sophisticated approach to jvm_options in general
since there’s multiple sources of them and they should have a strict, consistent ordering
eg, global+platform+task specific+target specific+cli-flags or something
a

aloof-angle-91616

02/18/2020, 11:35 PM
that is definitely what MirroredTargetOptionMixin and CompilerOptionSetsMixin are exactly created to do
f

fancy-queen-20734

02/18/2020, 11:35 PM
nice
a

aloof-angle-91616

02/18/2020, 11:35 PM
like exactly that
it has a specific precedence ordering that i believe aligns exactly with your message
f

fancy-queen-20734

02/18/2020, 11:36 PM
nice
For MirroredTargetOptionMixin, it’d be cool if it could use the same parsing infra as options. I’m not sure how to do that though — and don’t have time
a

aloof-angle-91616

02/19/2020, 8:34 PM
oh, that's super super interesting
do you have time to make an issue about what you're thinking?
i would love to hear it
2 Views