hundreds-father-404
03/13/2020, 2:15 PMred-balloon-89377
03/13/2020, 2:19 PM./v2
experience is amazing ❤️hundreds-father-404
03/13/2020, 2:32 PMred-balloon-89377
03/13/2020, 3:18 PMhundreds-father-404
03/13/2020, 3:26 PMimport ipdb; ipdb.set_trace()
, then run with --no-v2-ui --pytest-args='-s'
!aloof-angle-91616
03/13/2020, 7:23 PMhundreds-father-404
03/13/2020, 7:25 PMPantsRunIntegrationTest
-style tests because those depend on pants.pex
and that file will be out-of-date.
Personally, we never run those tests anymore at Toolchain, though, because tests for V2 code don’t use PantsRunIntegrationTest.
So, if Twitter / people working on V1 code like the JVM tests were fine with the risk of integration tests being stale from a stale pants.pex
, I’d be fine with turning on NO_REGEN_PEX
by defaultintegration
is in the file name, only then regen the Pex.
Although, this is not a safe heuristic. There are some tests that are PantsRunIntegrationTests
but don’t have integration
in the file name. There are also V2 tests with the name _integration_test.py
that don’t use PantsRunIntegrationTests
aloof-angle-91616
03/13/2020, 7:27 PMtests for V2 code don’t use PantsRunIntegrationTestwhy is this?
hundreds-father-404
03/13/2020, 7:29 PMsrc/python/pants
will invalidate the entire V1 integration test suite because pants.pex
will have changed
We do still have a couple PantsRunIntegrationTests
that touch V2 code, such as testing ./pants --no-v1 --v2 goals
, but the majority of tests don’t use italoof-angle-91616
03/13/2020, 7:30 PM