red-balloon-89377
04/01/2020, 4:27 PMif isinstance(current_target, JvmTarget):
# Some code...
if isinstance(current_target, RuntimePlatformMixin):
info["runtime_platform"] = current_target.runtime_platform.name
In CI, mypy complains that:
src/python/pants/backend/project_info/tasks/export_dep_as_jar.py: note: In member "_process_target" of class "ExportDepAsJar":
src/python/pants/backend/project_info/tasks/export_dep_as_jar.py:319:17: error:
Statement is unreachable [misc]
info["runtime_platform"] = current_target.runtime_plat...
^
Which is apparently a thing in the presence of multiple inheritance https://github.com/python/mypy/issues/3603
Is it okay to skip typechecking in this line, with a reference to the issue (or one of the follow ups, since that one is closed)? cc\ @hundreds-father-404hundreds-father-404
04/01/2020, 5:09 PM# type: ignore[call-args]
red-balloon-89377
04/01/2020, 5:14 PM[misc]
, right?hundreds-father-404
04/01/2020, 5:16 PMred-balloon-89377
04/01/2020, 5:22 PM