While waiting for Benjy s talk I was playing around with upg

Question

While waiting for Benjy s talk I was playing around with upgrading our 1 18 0 repo to 1 28 0rc1 I am running into a problem following the docs around ` source source roots` option In our old `pants ini` file the section is defined as a dictionary like so ``` source source roots 3rdparty go u go remote contrib go examples 3rdparty go u go remote app1 u python app2 u python ``` When I translate this to TOML ``` source source roots = 3rdparty go u go remote contrib go examples 3rdparty go u go remote app1 u python app2 u python ``` I get the following error ```DeprecationWarning DEPRECATED option source roots in scope source will be removed in version 1 30 0 dev0 Use roots instead ``` If I change `source roots` to `roots` I get this error `Invalid option roots under source in Users raul dev cb chartbeat pants toml` When I go to <https pants readme io docs source roots> it only talks about `root patterns` So I am confused about what to change the `source roots` to And I should note that works because I can see my settings when I run ` pants no verify config help advanced source`

hundreds-father-404 · Answer

Try root patterns I think that deprecation message has a stale message It s root patterns not roots

hundreds-father-404 · Answer

Also see <https github com pantsbuild pants blob master pants toml|https github com pantsbuild pants blob master pants toml> and search for source for an example

jolly-midnight-72759 · Answer

That works but does not produce the same results as v1 18 0 ``` source source roots= lt map gt default 3rdparty go go remote contrib go examples 3rdparty go go remote sharknado3 python sharknado python pycb cb conf python pycb cb path class python pycb cb check opentsdb python pycb cb mercury python A map of source roots for source code to list of languages Useful when you want to enumerate fixed source roots explicitly instead of relying on patterns DEPRECATED will be removed in version 1 30 0 dev0 Use roots instead ```

jolly-midnight-72759 · Answer

``` source source roots= lt map gt default src go src go src main go src go A map of source roots for source code to list of languages Useful when you want to enumerate fixed source roots explicitly instead of relying on patterns DEPRECATED will be removed in version 1 30 0 dev0 Use roots instead ```

happy-kitchen-89482 · Answer

Yeah that message is broken

happy-kitchen-89482 · Answer

it should be `root patterns` and it should just be a list of source roots without all the language details

happy-kitchen-89482 · Answer

I ll fix that error message to be less confusing

happy-kitchen-89482 · Answer

Thanks for the feedback

jolly-midnight-72759 · Answer

Cool

jolly-midnight-72759 · Answer

I was grepping through the code to find the message but `source roots` get s a lot of hits slightly smiling face

jolly-midnight-72759 · Answer

`src python pants source source root py` rocket question

jolly-midnight-72759 · Answer

But only `source roots` produces the same output as 1 18 0 ``` source source roots= lt map gt default 3rdparty go u go remote contrib go examples 3rdparty go yada yada``` When I use `root patterns` ` pants no verify config help advanced source` does not show the right thing

jolly-midnight-72759 · Answer

I ll make an issue because at the very least it is a CLI UI and documentation issue

jolly-midnight-72759 · Answer

hundreds-father-404 · Answer

Thanks Raúl Sorry for the confusing error message

jolly-midnight-72759 · Answer

It s `rc0` no apology necessary

jolly-midnight-72759 · Answer

But I think I am at a deadend because when I go to `src python pants source source root py` I see that it too is depreciated ``` register source root patterns metavar= lt list gt type=list fingerprint=True default=cls DEFAULT SOURCE ROOT PATTERNS advanced=True removal version= 1 30 0 dev0 removal hint= Use roots instead help=pattern help fmt format source ```

jolly-midnight-72759 · Answer

I don t know what the desired 1 30 0 UI is so I am not sure what to change it to slightly smiling face

hundreds-father-404 · Answer

Ah I think I see now That s confusing indeed So the preferred option is `root patterns` in the `source` scope aka ` source root patterns` It looks like that very similar option is called ` source source root patterns`

happy-kitchen-89482 · Answer

This would be maybe less confusing in the config file but as a flag it s pretty subtle