https://pantsbuild.org/ logo
f

fancy-summer-52431

05/18/2020, 6:19 PM
I suppose I should have filed an issue for it...
h

hundreds-father-404

05/18/2020, 6:20 PM
I recommend also pulling down Pants locally and running it with
./v2 --changed-since=HEAD fmt
to confirm thinks work before pushing to CI. See https://pants.readme.io/docs/contributor-setup for how to get set up
f

fancy-summer-52431

05/18/2020, 6:20 PM
Alright...
h

hundreds-father-404

05/18/2020, 6:22 PM
Looks like part of it is a bug. Try
./v2 fmt src/python/pants/util/strutil.py
, then try
./v2 --no-v2-ui fmt src/python/pants/util/strutil.py
also relevant, I think, is line 266-267 of
fmt.py
. It explains why isort doesn’t get the newline, as all the isort results are == to
sorted_results[-1]
f

fancy-summer-52431

05/18/2020, 6:27 PM
it'd be nice if the contributor setup offered advice on using
pyenv
2 Views