jolly-midnight-72759
05/28/2020, 3:40 PMpants.toml
format:
[GLOBAL]
backend_packages2.add = [
"loop",
"de",
]
Returns Expected "=", Whitespace, or [a-z], [A-Z], [0-9], "-", "_" but "." found.
for the third line. Removing .add
produces valid TOML according to this linter. Is the linter broken? (https://www.toml-lint.com/)enough-analyst-54434
05/28/2020, 3:52 PMenough-analyst-54434
05/28/2020, 3:54 PMenough-analyst-54434
05/28/2020, 3:55 PMjolly-midnight-72759
05/28/2020, 3:59 PMjolly-midnight-72759
05/28/2020, 4:00 PMhundreds-father-404
05/28/2020, 4:11 PMhundreds-father-404
05/28/2020, 4:13 PMjolly-midnight-72759
05/28/2020, 4:15 PMjolly-midnight-72759
05/28/2020, 4:15 PMpants.toml
yet.hundreds-father-404
05/28/2020, 4:16 PMI think I got it from Pants docs.Very possible. We used to recommend it. We might still have some stale references - I’ll audit
hundreds-father-404
05/28/2020, 4:17 PMWe have not fully moved over toNo worries. We’re keeping support until 1.31. You can also have some with Toml and some with Ini till then for an incremental migrationyet.pants.toml
jolly-midnight-72759
05/28/2020, 4:21 PM.toml
format. Now that I know about the version issue, we can ignore that error when checking.jolly-midnight-72759
05/28/2020, 4:21 PMjolly-midnight-72759
05/28/2020, 4:22 PMhundreds-father-404
05/28/2020, 4:22 PMhundreds-father-404
05/28/2020, 4:23 PMjolly-midnight-72759
05/28/2020, 4:23 PMjolly-midnight-72759
05/28/2020, 4:25 PMhundreds-father-404
05/28/2020, 4:27 PMhundreds-father-404
05/28/2020, 4:28 PMhundreds-father-404
05/28/2020, 4:31 PMjolly-midnight-72759
05/28/2020, 5:56 PMhundreds-father-404
05/28/2020, 6:15 PMThat sounds like something I could take onYay! Before writing this up, I’m trying to figure out how this will work.. Have you used Swagger/OpenAPI before? readme.com has an API reference feature where you can upload an OpenAPI document and it will set everything up for you. I think this is what we’ll want to use, but if you look at their examples at https://docs.readme.com/developers/reference/api-specification, they’re all HTTP end points.
What timescale are you looking to get it implemented?No particular deadline. The sooner it happens, the sooner people will have much better documentation on the site (compare
/pants targets --details=python_library
vs ./pants target-types --details=python_library
). But not something that needs to be done by a certain firm date.
Whenever someone is contributing, we try to remind them that it’s voluntary and should only be because you want to learn something new and/or improve the project 🙂
What does help for roadmap planning is communicating rough timelines, like “I hope to get to this this next week”. (Keeping in mind that doesn’t need to be a firm commitment)hundreds-father-404
05/28/2020, 6:24 PMjolly-midnight-72759
05/28/2020, 6:39 PMjolly-midnight-72759
05/28/2020, 6:40 PMhundreds-father-404
05/28/2020, 6:42 PMhundreds-father-404
05/28/2020, 6:42 PMhundreds-father-404
05/29/2020, 3:42 PM/target-types/python_library
and options/pytest
. It’s a little weird to do this, e.g. it would show “GET” next to them all. But it would work I think and allow us to use Readme.com.
2) Use an external host for API docs. Have readme.com simply link to it.
Any thoughts? Would #1 be confusing? cc @happy-kitchen-89482happy-kitchen-89482
05/29/2020, 6:04 PMhappy-kitchen-89482
05/29/2020, 6:07 PM