Hi, I’m getting a

ModuleNotFoundError

with v2 when I try to

./pants run

a particular Python target (the module not found is a package in our repo). It seems that the pex files are layed out differently between v1 and v2 (or else I’ve misconfigured things?), but the v1 puts the dependency package (“ns_python_logger”) in the root directory while v2 puts it under a path that mirrors our repo (“lib/python_logger/src/ns_python_logger”).

that is likely due to the configuration for source roots changing a bit: sorry about that

Thanks for the link. I read the page, but it’s not clear to me how to make this work without reconfiguring the whole repo.

in the example above, do you have a

BUILD

file at

lib/python_logger/src/

?

yes

ok. so one of the behaviors in v1 that i’m not sure was preserved was that a target was its own source root if it wasn’t below a source root

ok, I’ll give that a try

@cuddly-window-48195: oh, also: what version is this?

1.28

got it: thanks. there have been a few more changes in 1.29.x … lemme see if they are relevant

👀

…so, yes. it did change a bit further in 1.29.x i think. @cuddly-window-48195: 1.29.0 will likely be released today, so you might consider trying out

1.29.0rc4

Yeah, so that pattern might work, or if not you can explicitly mark source roots with an empty dummy file (like "SOURCE_ROOT"), if you first set:

[source]
marker_filenames: ["SOURCE_ROOT"]

Ok, I’ll bump up to 1.29. I started with the configuration file here: https://github.com/pantsbuild/example-python/blob/master/pants.toml Which had

root_patterns = [ '/' ]

.

ah… so

We changed it to that recently, because "repo root is python source root" is not uncommon.

@cuddly-window-48195: did you already have an existing

pants.ini

file?

Also I should update the docs to include marker files.

it might not be clear, but

pants.ini

files can be converted into

pants.toml

files, and if you bump version-at-a-time you’ll get lots of (hopefully helpful) deprecation warnings

Sorry, I didn’t see the new notifications. I did have a pants.ini file previously; I was getting errors so I decided to try starting with the example file and working backwards to our old configuration.

today we think 😃

I’m only seeing an rc4 and then a 1.30.0.dev0

so, based on this feedback, we’re actually going to try and improve the sourceroot defaults a bit! so 1.29.0 won’t be today: maybe monday

Sorry for the long delay, this did help; however, it only seems to work for 1.28.0. With 1.29.0rc4, I got this error:

17:51:47:253 [ERROR] 1 Exception encountered:

  InvalidFieldException: Unrecognized field `source=ns_cli_deploy/cli.py` in target apps/cli_deploy/src:lexio-deploy. Valid fields for the target type `python_binary`: ['_transitive', 'always_write_cache', 'compatibility', 'dependencies', 'description', 'emit_warnings', 'entry_point', 'ignore_errors', 'inherit_path', 'no_cache', 'platforms', 'provides', 'scope', 'shebang', 'sources', 'tags', 'zip_safe'].

yea… in 1.28 you should see deprecation warning for it?

No deprecation warning, but removing special cases sounds good. 👍 Thanks for the work you’re doing; I’m excited for v2!

… hm. that’s odd. sorry about that. i think that the deprecation might only trigger in some limited cases.

Change for the source root defaults: https://github.com/pantsbuild/pants/pull/10043