https://pantsbuild.org/ logo
Powered by
p

polite-vase-75369

07/21/2020, 2:56 PM
and struggling to get groovy and jenkins to escape the *
a

aloof-angle-91616

07/21/2020, 2:56 PM
what pants command line are you executing and what error are you seeing?
(i have a meeting in a bit so will have to come back in an hour, quite sorry)
p

polite-vase-75369

07/21/2020, 2:58 PM
im trying to run 
./pants --changed-parent=HEAD~1 list
but a warning about crypto library is polluting the output
a

aloof-angle-91616

07/21/2020, 2:58 PM
that was fixed by the pex upgrade as well
i know it's difficult to do more than one thing at once but it will make it a lot easier for us to help you if you have the time to spare to migrate up to more recent pants. you can do it one version at a time
p

polite-vase-75369

07/21/2020, 3:01 PM
still struggling to get python3 100%, so that’s a roadblock lol
❤️ 1
a

aloof-angle-91616

07/21/2020, 3:02 PM
oh ouch ok then
p

polite-vase-75369

07/21/2020, 3:02 PM
life’s a mess 😄
a

aloof-angle-91616

07/21/2020, 3:02 PM
haha yes indeed
h

hundreds-father-404

07/21/2020, 3:02 PM
Is this to upgrade your plugin to python 3? To clarify, your own code can be python 2! It’s only your plugins.
p

polite-vase-75369

07/21/2020, 3:04 PM
other people are working on the python3 issue, im just trying to see why this command just started breaking
nothing should have been changed on that front
doesn’t seem to work, i might be escaping it incorrectly tho
h

hundreds-father-404

07/21/2020, 3:06 PM
Do you reproduce the warning locally? That flag is designed for deprecated Pants options - I’m not certain it would impact Pex output.
p

polite-vase-75369

07/21/2020, 3:09 PM
no, so that sounds like cryptography updated, lemme try to pin it
👍 1
h

hundreds-father-404

07/21/2020, 3:10 PM
Or, one of its dependencies are allowed to float and that was updated
p

polite-vase-75369

07/21/2020, 3:11 PM
awwwwesome, that worked!
❤️ 1
gotta get on that python3 tho
👏 1
a

aloof-angle-91616

07/21/2020, 3:11 PM
let us know if we can help!!
h

hundreds-father-404

07/21/2020, 3:12 PM
Great! What was the fix? With python3, would it help for me to pair with anyone? I led Pants’s migration to Python 3, along with upgrading Twitter’s plugins. I’d be happy to help. Again, the scope is only upgrading your plugins - not your entire codebase.
p

polite-vase-75369

07/21/2020, 3:14 PM
i pinned crypto to the version that was working on my laptop (whatever was in .cache dir lol). that’s a very generous offer @hundreds-father-404, do u mind if i pass it onto the engineers working on it to see what they think?
❤️ 1
and yep i understand, it’s just about upgrading pants itself to py3
👍 1
h

hundreds-father-404

07/21/2020, 3:16 PM
Absolutely. They can reach out to me on Slack or at eric@toolchain.com Pants has seen some pretty huge improvements this past year, and we’d love for your org to benefit from it. We also recognize that sometimes the upgrades are non-trivial, so want to help as much as we can to ease that.
p

polite-vase-75369

07/21/2020, 3:17 PM
yeah, we also gotta switch from ivy to coursair, it seems a lot better. but that’s a different story
h

hundreds-father-404

07/21/2020, 3:21 PM
I think we kept Ivy until 1.27 iirc, so that one hopefully won’t block a couple upgrades. But it does indeed make life better. Meanwhile, Python 3 may bring you a nice performance boost: https://twitter.com/earellanoaz/status/1142213266384416773?s=21
7 Views
Powered by