aloof-angle-91616
07/24/2020, 9:20 PMhundreds-father-404
07/24/2020, 9:23 PM!
ignores now: https://github.com/pantsbuild/pants/blob/master/src/python/pants/engine/internals/graph.py#L612hundreds-father-404
07/24/2020, 9:23 PMdependencies
fieldaloof-angle-91616
07/24/2020, 9:25 PMaloof-angle-91616
07/24/2020, 9:26 PMaloof-angle-91616
07/24/2020, 9:26 PMaloof-angle-91616
07/24/2020, 9:26 PMaloof-angle-91616
07/24/2020, 9:26 PMhundreds-father-404
07/24/2020, 9:27 PMthat’s probably less of a concern than in general giving a good error message on a missing import when using dep inferencedep inference no-ops when we can’t infer a dep or when there are >1 owner for that import
aloof-angle-91616
07/24/2020, 9:27 PMhundreds-father-404
07/24/2020, 9:29 PMModuleNotFoundError
and can then add an explicit dep
Generally, dep inference is written to be as conservative as possible. We’d rather have false negatives than false positiveshundreds-father-404
07/24/2020, 9:29 PMenough-analyst-54434
07/24/2020, 10:00 PMaloof-angle-91616
07/24/2020, 10:01 PMaloof-angle-91616
07/24/2020, 10:01 PMpython_requirements()
macro's relationship to generating targets isn't 100% clear to some people\aloof-angle-91616
07/24/2020, 10:02 PMPyYAML
when the import is named `pyyaml`"aloof-angle-91616
07/24/2020, 10:02 PMenough-analyst-54434
07/24/2020, 10:06 PMaloof-angle-91616
07/24/2020, 10:06 PMaloof-angle-91616
07/24/2020, 10:07 PM