https://pantsbuild.org/ logo
#general
Title
# general
h

happy-kitchen-89482

07/29/2020, 12:43 AM
Thoughts on getting rid of
Optionable
as a separate thing and merging it into
Subsystem
(now that the latter is the only
Optionable
) Vs. keeping those as separate concepts? Would require moving
subsystem.py
to
src/python/pants/option
.
h

hundreds-father-404

07/29/2020, 12:44 AM
Please do! I would love to see this. Imo, our options system is pretty complex. Powerful, but complex. Refactoring like this will make it easier for us to do something like re-invent options to work with MyPy automatically
w

witty-crayon-22786

07/29/2020, 12:53 AM
the only “not currently working but should probably be revived” thing is scoped subsystems.
so yea, assuming currently working stuff continues to work and it doesn’t block that, then works for me.
👍 2
3 Views