#general
Title
j
jolly-midnight-72759
08/24/2020, 8:30 PMSeeking clarification on the "broken until 2.0.0 note" in https://www.pantsbuild.org/docs/target-api-extending-targets
We have a
jupyter Copy code
class JupyterRepl(ReplTaskMixin, PythonExecutionTaskBase):
""" Run a pants aware jupyter notebook """h
hundreds-father-404
08/24/2020, 8:36 PMNo, only this specific mechanism of adding a new field to a pre-exiting target doesn’t work. That was never an option with V1 plugins - it’s a new mechanism added thanks to V2
j
jolly-midnight-72759
08/24/2020, 8:37 PMdoh.
I was hoping I could wait to update this plugin until 2.0.0. No excuse now. 🙂
🚧 back to figuring out how to make
Exception message: Failed to load the jupyter.register backend: ModuleNotFoundError("No module named 'pants.backend.python.python_requirement'",)h
hundreds-father-404
08/24/2020, 8:40 PMCc @happy-kitchen-89482 , I’m ooo till Thursday so not able to take a closer look.
But yeah, I think “extending pre-exiting target types” is a red herring. If you didn’t need it before for your Jupyter plug-in, you shouldn’t need it here. That new mechanism is mostly for when you’re adding new codegen implementations
j
jolly-midnight-72759
08/24/2020, 8:43 PMThis plugin worked fine under 1.18. It seems to extend
ReplTaskMixinPythonExecutionTaskBaseI have another plugin for Sphinx doc that is working, so I will use that as a model to figure it out.
thank you!
h
hundreds-father-404
08/24/2020, 8:44 PMOh. Try importing from pants.python instead of pants.backend.python. Iirc we moved that import. If you jumped multiple versions, you’d miss the deprecation
j
jolly-midnight-72759
08/24/2020, 8:46 PMThat was helpful. New error now. "No module named 'pants.python.targets'"
I'll check the mailing list to see if I can find the depreciation email
🚀
Copy code
pants.backend.python.tasks.python_execution_task_base
pants.backend.python.targets.python_requirement_library
pants.backend.python.targets.python_requirement_libraryAre still working in engine v1 in pants 1.25.
👍 1
h
hundreds-father-404
08/24/2020, 8:59 PMSo yeah, those are still backend.python. Only a couple things moved to python
j
jolly-midnight-72759
08/24/2020, 8:59 PMkeeping me on my toes!
h
hundreds-father-404
08/24/2020, 9:00 PMThose imports will be the same until 2.0, where we delete the V1 target definitions in favor of the V2 Target API
👍🏽 1
j
jolly-midnight-72759
08/24/2020, 9:00 PMI'm hoping the jump to 1.25 will be the hard part. Hoping to be at 1.30 by the end of the week. And maybe V2.
👍 1
❤️ 1
h
hundreds-father-404
08/24/2020, 9:02 PMPlease keep asking for any help that will help you to upgrade!
👖 1
j
jolly-midnight-72759
08/24/2020, 9:02 PMWill do.
h
happy-kitchen-89482
08/24/2020, 9:16 PMYep, we're here to help!
5 Views