Is pants doing something on ulimit_n on Mac OS?

❯ ipython
Python 3.7.5 (default, Dec 26 2019, 04:25:18)
Type 'copyright', 'credits' or 'license' for more information
IPython 7.11.1 -- An enhanced Interactive Python. Type '?' for help.
In [1]: import jedi
In [2]: import resource
In [3]: resource
Out[3]: <module 'resource' from '/Users/leozc/.pyenv/versions/3.7.5/lib/python3.7/lib-dynload/resource.cpython-37m-darwin.so'>
In [4]: resource.getrlimit(resource.RLIMIT_NOFILE)
Out[4]: (65536, 9223372036854775807) 
in sandbox

While kick the run in pants

❯ ./pants repl helloworld/rayburst.py #my own app
Python 3.7.5 (default, Dec 26 2019, 04:25:18)
[Clang 11.0.0 (clang-1100.0.33.8)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
(InteractiveConsole)
>>> import resource
>>> resource.getrlimit(resource.RLIMIT_NOFILE)
(9223372036854775807, 9223372036854775807)

❯ ./pants --version 185817.15 [INFO] initializing pantsd... 185817.89 [INFO] pantsd initialized. 2.1.0rc0

we attempt to increase the ulimit if we can, yea

rlimit:Resource:NOFILE.set(max, max) ^^ should we be more conservative? The number above is way too big IMHO, also some app using the

min

to guess connection count see here

mm. interesting. yea, we could be more conservative. we know that 10k is a safe value for pants, so we could avoid setting it higher than

min(current_value, 10k)

pls see above the number above

resource.getrlimit(resource.RLIMIT_NOFILE)
(9223372036854775807, 9223372036854775807)

@plain-sundown-25537: the two values are the “soft” and “hard” limits, respectively

yes - the soft and hard both very big - see above

if the hard limit is that high, it’s because someone with root has configured it that way on your machines

I was on Macos Big Sur

ah. i wonder if they changed the default then

That is what I am thinking too, I don’t think anyone would ever come up such big number

ok… i can make a quick change to do roughly

soft_limit = min(hard_limit, 10k)

IMHO both sides should do something - Ray needs to be more robust, Pants needs to avoid the number blowing up too much

2.0.x is enough.. sorry for having this answered 6 months late