https://pantsbuild.org/ logo
#general
Title
# general
j

jolly-midnight-72759

01/03/2021, 9:36 PM
One of our basic tests is failing on v2.1.1. When I run
pants list ::
it exits with status 1. When I do
for p in $(fd -t d -d 1 .) ; do echo $p ; ./pants list ${p}:: ; done
(i.e. for every directory run,
.pants list ${DIRNAME}::
) and also
.pants list :
I get a list of directories and it exits with status 0. I have print stack trace set to to true and also ran with
-ldebug
. No additional output was provided. Help with debugging would be appreciated.
I removed the hack we had that increased recursion limit because I believe it is fixed in this version:
Copy code
# XXX HACK UNTIL <https://github.com/pantsbuild/pants/issues/11201> is fixed
sys.setrecursionlimit(4096)
The test fails even when I add this hack back.
Switching to version
2.1.0
told me one of my
BUILD
files had
python_binary
. When I fixed that it now works under both
2.1.0
and
2.1.1
. Please let me know what you'd like me to run so you can reproduce.
-ldebug
did not give any output.
h

happy-kitchen-89482

01/03/2021, 10:38 PM
Hi Raúl, sorry for the trouble. Someone will look into this ASAP, but probably not until tomorrow, due to the new years holiday
j

jolly-midnight-72759

01/03/2021, 11:13 PM
No hurry. Happy to help diagnose whenever
Tomorrow, I'll clean my caches and revert the change to make sure I can reproduce it.
w

witty-crayon-22786

01/04/2021, 5:47 PM
Do you have any pants_ignore_warnings filters set?
j

jolly-midnight-72759

01/04/2021, 6:05 PM
d'oh! Looks like we prematurely added
ignore_pants_warnings = [".*"]
. Removing that gives me the errors. It looks like 2.1.1 better respects that setting than 2.1.0. Is this worth mentioning on https://www.pantsbuild.org/docs/release-notes-2-1 ?
Thank you! @witty-crayon-22786
w

witty-crayon-22786

01/04/2021, 6:07 PM
np. it was this one:
Copy code
Bugfixes

    Fix filtering of log messages generated in native code. (cherrypick of #11313) (#11316) PR #11316
👍🏽 2
h

hundreds-father-404

01/05/2021, 12:06 AM
I’m confused why this is causing an exit code of 0, though? Deprecations shouldn’t impact the exit code
j

jolly-midnight-72759

01/05/2021, 12:09 AM
It was a non-zero exit code because of an unrecognized target:
python_binary
. 2.1.0 showed the error (even with the aggressive ignore), but 2.1.1 just exits with code 1, no output.
h

hundreds-father-404

01/05/2021, 12:09 AM
Ahh, cool, so that’s an expected error. Thanks!
👍🏽 1
5 Views