https://pantsbuild.org/ logo
#general
Title
# general
l

loud-stone-83419

01/04/2021, 11:00 AM
Not sure if this is the proper location for feedback: In pants v1 there is in the Junit module a way to have safe args if too long through argfile, which is great but assumes the Junit module is compatible with the argfile format. Since Java CLI is compatible with argfile it would be great if argfile safety could be put at the Java process execution layer so that a module that uses that subsystem doesn't have to handle it. ie as I was doing the integration for scalatest, the scalatest runner don't handle argfiles, so I needed to get around that instead of having the safety provided by a higher level of abstraction. Might be something tricky about caches though that I may not realize. That's mostly voiced in perspective for v2 JVM integration Let me know if I need to clarify 🙂 Thanks for the great work! and happy new year!
e

enough-analyst-54434

01/04/2021, 3:08 PM
Ah, @loud-stone-83419 your premise is not accurate. The java CLI Pants v1 was developed against did not support argfiles unlike javac. The java CLI only gained this support in Java 9 in 2017: https://bugs.openjdk.java.net/browse/JDK-8027634
l

loud-stone-83419

01/04/2021, 3:56 PM
My bad - thx for the explanation!
4 Views