https://pantsbuild.org/ logo
#general
Title
# general
h

helpful-lunch-92084

01/26/2021, 3:58 AM
hey, just ran into this issue: 1. I run pants test :: and it kicks off a bunch of parallel tests via subprocesses. 2. One of the tests fails during requirements.pex building due to a missing dep (like we run our own cheeseshop and don’t fall through to pypi - it’s not great, but we have reasons for this) 3. Pants exits 4. The subprocesses stay active as orphaned procs Eventually they die. Now I don’t know (since i lose their stdout/err) if they die because they also ran into issues, or they completed, or if pants is just delayed in killing them. Since they’re owned by init I feel like it’s the former, in which case pants isn’t cleaning them up properly. Just thought I’d flag. Seems like a kill to the pgid would solve this after handling the initial subprocess exception. Sorry, I don’t have a great test case for this.
h

hundreds-father-404

01/26/2021, 3:59 AM
Hey Nate, thanks for flagging. What pants version is this?
h

helpful-lunch-92084

01/26/2021, 4:00 AM
2.2.0
h

happy-kitchen-89482

01/26/2021, 4:18 AM
cc @witty-crayon-22786
w

witty-crayon-22786

01/26/2021, 5:04 PM
thanks for the report!
@helpful-lunch-92084: did you confirm that the processes were owned by
init
, and not by
pantsd
?
pantsd
won’t die if a single test fails, so it should have continued to parent them
BUT, they should still have exited when one client went away: i’ll file a ticket about that once we have more info on the
init
question.
h

helpful-lunch-92084

01/26/2021, 5:11 PM
yah the ppid was 1 for them
w

witty-crayon-22786

01/26/2021, 5:30 PM
is
pantsd
enabled…?
h

helpful-lunch-92084

01/26/2021, 5:46 PM
yah
w

witty-crayon-22786

01/26/2021, 5:46 PM
interesting! do you still have the
pantsd
log from that run?
.pants.d/pantsd/pantsd.log
?
h

helpful-lunch-92084

01/26/2021, 6:00 PM
let me try to clear it and redo it since it’s quite full from other stuff
w

witty-crayon-22786

01/26/2021, 6:00 PM
thank you!
might need to restart pantsd are removing it.
h

helpful-lunch-92084

01/26/2021, 6:01 PM
gtk thx
w

witty-crayon-22786

01/26/2021, 6:01 PM
…i suspect that i know what happened, but the log will confirm!
filed the above as https://github.com/pantsbuild/pants/issues/11618 after ~endless slack snoozing! sorry about that
👍 1
6 Views