https://pantsbuild.org/ logo
#general
Title
# general
h

happy-kitchen-89482

03/16/2021, 12:19 AM
I notice in our integration test infra that integration tests aren't hermetic in practice if
use_pantsd=True
, even if
hermetic=True
?
w

witty-crayon-22786

03/16/2021, 1:44 AM
They're running in a sandbox with limited env and explicit input files... So unless they depend on
pants.toml
they should be pretty isolated independent of that flag.
h

happy-kitchen-89482

03/16/2021, 3:37 AM
I'm seeing different in practice
tests that fail unless I set
use_pantsd=False
, and the failure is due to reading the real
pants.toml
w

witty-crayon-22786

03/16/2021, 3:38 AM
when you say “real”, do you mean a copy inside the sandbox?
our integration tests transitively depend on
pants.toml
, but that means that it is included in the sandbox
see
./pants filedeps --transitive src/python/pants/option/:integration
for example
h

happy-kitchen-89482

03/16/2021, 4:08 AM
Presumably copy inside the sandbox, but that is what
hermetic=True
is supposed to finesse, no?
w

witty-crayon-22786

03/16/2021, 4:10 AM
whether or not there is a copy inside the sandbox is controlled by the target definition…
python_integration_tests
transitively includes a lot of stuff: https://github.com/pantsbuild/pants/blob/master/pants-plugins/python_integration_tests_macro.py
h

happy-kitchen-89482

03/16/2021, 4:25 AM
I'm fine if there is a copy inside the sandbox,
hermetic=True
is supposed to tell the pants run under test to ignore it
By setting
--pants-config-files=[]
4 Views