bored-art-40741
03/21/2021, 9:32 PMenough-analyst-54434
03/21/2021, 9:33 PMenough-analyst-54434
03/21/2021, 9:34 PMenough-analyst-54434
03/21/2021, 9:34 PMenough-analyst-54434
03/21/2021, 9:34 PMbored-art-40741
03/21/2021, 9:37 PMmain
update and I think it's correct, let me rebase and see if it still reprosbored-art-40741
03/21/2021, 9:44 PM* Checking shell scripts via shellcheck
In ./build-support/bin/create_s3_index_file.sh line 19:
for obj in $(aws s3 ls "s3://${VERSION_DIR}/" | grep "\.whl" | awk '{print $4}'); do
^-- SC1117: Backslash is literal in "\.". Prefer explicit escaping: "\\.".
In ./build-support/bin/create_s3_index_file.sh line 26:
echo "<br><a href=\"${URL//+/%2B}\">${obj}</a>\n";
^-- SC1117: Backslash is literal in "\n". Prefer explicit escaping: "\\n".
In ./build-support/bin/rust/calculate_engine_hash.sh line 40:
| grep -v -E -e "/BUILD$" -e "/[^/]*\.md$" \
^-- SC1117: Backslash is literal in "\.". Prefer explicit escaping: "\\.".
In ./build-support/common.sh line 7:
CLEAR_LINE="\x1b[K"
^-- SC1117: Backslash is literal in "\x". Prefer explicit escaping: "\\x".
In ./build-support/common.sh line 8:
COLOR_BLUE="\x1b[34m"
^-- SC1117: Backslash is literal in "\x". Prefer explicit escaping: "\\x".
In ./build-support/common.sh line 9:
COLOR_RED="\x1b[31m"
^-- SC1117: Backslash is literal in "\x". Prefer explicit escaping: "\\x".
In ./build-support/common.sh line 10:
COLOR_GREEN="\x1b[32m"
^-- SC1117: Backslash is literal in "\x". Prefer explicit escaping: "\\x".
In ./build-support/common.sh line 11:
COLOR_RESET="\x1b[0m"
^-- SC1117: Backslash is literal in "\x". Prefer explicit escaping: "\\x".
In ./build-support/common.sh line 19:
(($# > 0)) && log "\n${COLOR_RED}$*${COLOR_RESET}"
^-- SC1117: Backslash is literal in "\n". Prefer explicit escaping: "\\n".
In ./build-support/common.sh line 24:
(($# > 0)) && log "\n${COLOR_GREEN}$*${COLOR_RESET}"
^-- SC1117: Backslash is literal in "\n". Prefer explicit escaping: "\\n".
In ./build-support/common.sh line 46:
echo -en "travis_fold:${action}:${slug}\r${CLEAR_LINE}"
^-- SC1117: Backslash is literal in "\r". Prefer explicit escaping: "\\r".
In ./build-support/githooks/prepare-commit-msg line 38:
grep "\[ci skip-rust\]" "${COMMIT_MSG_FILEPATH}" > /dev/null
^-- SC1117: Backslash is literal in "\[". Prefer explicit escaping: "\\[".
^-- SC1117: Backslash is literal in "\]". Prefer explicit escaping: "\\]".
In ./build-support/githooks/prepare-commit-msg line 40:
grep "\[ci skip-build-wheels\]" "${COMMIT_MSG_FILEPATH}" > /dev/null
^-- SC1117: Backslash is literal in "\[". Prefer explicit escaping: "\\[".
^-- SC1117: Backslash is literal in "\]". Prefer explicit escaping: "\\]".
Please fix the above errors and run again.
bored-art-40741
03/21/2021, 9:44 PM$ git log
commit d42ba3751a9e835ba4b2818c09c17555d5565e86 (HEAD -> main)
Author: Patrick Lawson <patrick.a.lawson@gmail.com>
Date: Sat Mar 20 22:47:47 2021 -0400
WIP: JVM repl with coursier resolve
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]
# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
commit 4210c6c9dece3ff6d0c00b318b880bd6050c3e96 (origin/main)
Author: John Sirois <john.sirois@gmail.com>
Date: Sun Mar 21 13:01:10 2021 -0700
Use append_only_caches in Pex processes. (#11760)
bored-art-40741
03/21/2021, 9:44 PMbored-art-40741
03/21/2021, 9:46 PMshellcheck
is called, it seems plausible that version drift is causing different resultsbored-art-40741
03/21/2021, 9:47 PM$ shellcheck --version
ShellCheck - shell script analysis tool
version: 0.5.0
enough-analyst-54434
03/21/2021, 10:01 PM$ shellcheck --version
ShellCheck - shell script analysis tool
version: 0.7.1
license: GNU General Public License, version 3
website: <https://www.shellcheck.net>
I'll poke at this.bored-art-40741
03/21/2021, 10:02 PMapt install shellcheck
on Debian 10.8hundreds-father-404
03/21/2021, 10:18 PMenough-analyst-54434
03/21/2021, 10:26 PMdocker run --rm -it debian:10.8 bash -i
then apt install shellcheck python3-dev git curl
in a fresh clone of pants. But grabbing latest shellcheck from curl -sSL <https://github.com/koalaman/shellcheck/releases/download/stable/shellcheck-stable.linux.x86_64.tar.xz> -O
and setting up that to win, errors go away.enough-analyst-54434
03/21/2021, 10:30 PMbored-art-40741
03/21/2021, 10:31 PMhundreds-father-404
03/21/2021, 10:34 PMenough-analyst-54434
03/21/2021, 10:37 PMenough-analyst-54434
03/21/2021, 10:40 PMenough-analyst-54434
03/21/2021, 10:40 PMhundreds-father-404
03/21/2021, 10:41 PMenough-analyst-54434
03/21/2021, 10:42 PMenough-analyst-54434
03/21/2021, 10:43 PMhundreds-father-404
03/21/2021, 10:43 PMThat lets plugin publisher just use standard Python install_requires.Oh, duh. That makes a lot of sense. Right now, the pants_requirement() macro does exact version requirements but that could be adjusted to allow plugin authors to express compatibility more flexibly
enough-analyst-54434
03/21/2021, 10:43 PMenough-analyst-54434
03/21/2021, 10:44 PMhundreds-father-404
03/21/2021, 10:44 PMMy point is thats not a new problem. It snot a v2 world issue - its an old one.Ack, I meant instead that we probably want to figure this old problem out before re-starting to publish plugins and setting some precedent. The only (known) v2 plugin is the Toolchain one
enough-analyst-54434
03/21/2021, 10:48 PMenough-analyst-54434
03/21/2021, 10:48 PM