I just added

skip_pylint=True

to a lot of BUILD files, but pylint is still reporting errors on py files in those directories. Any idea what I'm missing? https://github.com/st2sandbox/st2/commit/aa2ba3a2bb8540fbc80f82d644ba2c7ffad2d3a0

Oh, did you add to the

python_tests()

targets as well? (Sorry, we know this is very stinted and not super intuitive. Again, we really want to re-envision targets)

Oh, do I need to add to

python_tests()

? I thought it was only an option for

python_library()

Yeah, if you want to skip running on the test files too.

python_library()

is metadata for non-test Python files, whereas

python_tests

is metadata for test files

hmm. ❔ Do I need to have

python_library()

in the tests directories' BUILD files then?

Depends if your

__init__.py

file has content in it or not.

python_library()

will give metadata for

__init__.py

because it's technically not a test file But if your

__init__.py

files are completely empty, then you can skip having those

python_library

targets for them - Pants will still look for the files and include them in chroots no matter what Otherwise, you need the target so Pants can do things like dependency inference for the file

And in this case, you're only talking about

__init__.py

in the tests directories right?

Yeah, unless you overrode the

sources

field, each target only gives metadata for the directory it's located in. So the

python_library

for tests/my_project/BUILD` would describe the metadata for files like

tests/my_project/__init__.py

and

tests/my_project/some_test_util.py

, but not

tests/my_project/test_app.py

The

./pants filedeps

goal might make this a little more clear (Assuming you used

./pants tailor

) try running

./pants filedeps tests/my_project

and

./pants filedeps tests/my_project:tests

. https://www.pantsbuild.org/docs/project-introspection#filedeps---find-which-files-a-target-owns

I do have

[python-infer].inits = true

because in the code (not the tests) init files sometimes DO have code in them.

Got it. Although,

./pants tailor

isn't that fancy to look at that option. Instead, it simply sees there is a file

__init__.py

that matches the default sources for `python_library`:

(*.py, !*_test.py, !test_*.py, !tests.py, !conftest.py)

. Regardless of

[python-infer].inits

,

./pants tailor

will generate those targets - so probably simpler for you to keep them

I think so, because it says 700ish files instead of 1100ish files.

Great!

Yes. That did it. 🙂 I'm getting a much more reasonable set of issues now 🙂

Glad to hear. Please do keep the feedback and ideas coming 🙂 this feature was a great suggestion!

And

./pants tailor

does add python_library again after I removed it. 😕

Yeah 😐 I'm not sure what the story should be for how to opt out of generating certain targets Fwit, you don't need to worry about adding

skip_pylint=True

to those

python_library

targets because it doesn't matter if you run it over those empty init.py files or not

testing that ...