Hey Pants, we're seeing an error about using

--changed-since

at the same time as target arguments but it's not in the command at all:

./pants import-fixer --jobs=cross-imports --import-fixer-output-file=cross_imports_output.json app/::
17:27:47.34 [INFO] Initializing scheduler...
17:27:47.50 [INFO] Scheduler initialized.
17:27:47.53 [ERROR] You used `--changed-since` at the same tie as using target arguments. Please use only one.
Traceback (most recent call last):
  ​File "/home/ubuntu/workspace/backend_master/.cache/pants/setup/bootstrap-Linux-x86_64/2.5.1rc3_py38/lib/python3.8/ite-packages/pants/bin/daemon_pants_unner.py", line 125, in single_daemonized_run
    ​runner = LocalPantsRunner.create(
  ​File "/home/ubuntu/workspace/backend_master/.cache/pants/setup/bootstrap-Linux-x86_64/2.5.1rc3_py3/lib/python3.8/site-package/pants/bin/local_pants_runner.py", line 150, in create
    ​specs = calculate_specs(
  ​File "/home/ubuntu/workspace/backend_master/.cache/pants/setup/bootstrap-Linux-x86_64/2.5.1rc3_py38/lib/pthon3.8/site-packages/pants/init/specs_calculator.py", line 47, in calculate_specs
    ​raise InvalidSpecConstraint(
pants.init.specs_calculator.InvalidSpecConstraint: You used `--changed-since` at the same time as using target arguments. Please use only one.
+ ./pants import-fixer --jobs=wildcard-imports --ignore-skip --json-output --import-fixer-output-file=wildcard_imports_output.json app/::
17:27:48.10 [ERROR] You used `--changed-since` at the same time as using target arguments. Please use only one.
Traceback (most recent call last):
  ​File "/home/ubuntu/workspace/backend_master/.cache/pants/setup/bootstrap-Linux-x86_64/2.5.1rc3_py38/lib/python3.8/site-packages/pants/bin/daemon_pants_runner.py", line 125, in single_daemonized_run
    ​runner = LocalPantsRunner.create(
  ​File "/home/ubuntu/workspace/backend_master/.cache/pants/setup/bootstrap-Linux-x86_64/2.5.1rc3_py38/lib/python3.8/site-packages/pants/bin/ocal_pants_runner.py", line 150, in create
    ​specs = calculatespecs(
  ​File "/home/ubuntu/workspace/backend_master/.cache/pants/setup/bootstrp-Linux-x86_64/2.5.1rc3_py38/lib/python3.8/site-packages/pants/init/specs_calculator.py", line 47, in calculat_specs
    ​raise InvalidSpecConstraint(
pants.init.specs_calculator.InvalidSpecConstraint: Youused `--changed-since` at the same time as using target arguments. Please use only one.

I tested the goal locally with no issues. Any ideas why this would happen?

I wonder if it's set via an env var or pantsrc file, perhaps? Do you reproduce on multiple machines?

I've only seen this happen in CI as of earlier today. We use the changed since option in line earlier in the build. This command above is invoked later in the build to run a custom plugin.

Huh. Did something change recently, like a pants upgrade or changes to your plugin?

the only thing we changed is on the main build we started running

./pants dependees --changed-since=${LAST_RELEASE_COMMIT} --dependees-output-file=pants_dependees.txt

this is called before the command above. Seems like it could have started happening around the same time actually

Might be worth experimenting with inverting the order, and possibly disabling Pantsd This should not be happening if it is, to be clear

and very specially we started running changed-since with a commit hash and not a remote branch name

Any luck?

I jsut wanted to get this output before disabling pantsd and share here: https://gist.github.com/njgrisafi/aa336771dfa4557b339de0c6926125e9 will try pantsd now

Thanks for running with ldebug!

215627.04 [DEBUG] specs are: Specs(address_specs=AddressSpecs(literals=(), globs=(DescendantAddresses(directory='app'),), filter_by_global_options=True), filesystem_specs=FilesystemSpecs(includes=(), ignores=()))

215627.04 [DEBUG] changed_options are: ChangedOptions(since='6db38768e8de2a4182a32b55d329e6c398800b77', diffspec=None, dependees=<DependeesOption.NONE: 'none'>)

hmm idt that shouldn't happen. We're trying to run a completely separate command on the

app/::

targets. Maybe I can force it not to use the cache by running

::

instead?

Yeah it should not have the changed-since option still...did Pantsd make a difference? How are you setting --changed-since in the prior command?

but at this point I think pantsd should help. I just enabled the option when running these goals. Will see how it does

Hmmm. I'm wondering what would happen if you ran a different, not custom goal after that dependees one? I'm wondering if somehow the custom goal is the culprit You said this doesn't reproduce locally?

maybe the goal is the issue but not sure how. It's similar to the one here: https://github.com/njgrisafi/pants-example/tree/import-fixer maybe we're holding something wrong?

So reordering fixed it. What about going back to bad order and adding an immediate goal that runs ./pants list app::?

let me try that

Well good news is that it is not related to your custom goal! Ik I'm a broken record, but it would be helpful to triple check your env vars and config file to see if they are setting PANTS_CHANGED_SINCE or [changed].since. Note that the CLI would override if that was the case, so that arg being set is not proof that the env var isn't also set Another thing you could try is run ./pants list at the beginning of the run, with no args. Does it give back results or does it warn no targets specified

haha yes good to know! We are not setting

PANTS_CHANGED_SINCE

in a config or as an env. We only ever add it as an option on the

dependees

goal.

Another thing you could try is run ./pants list at the beginning of the run, with no args. Does it give back results or does it warn no targets specified

sure I can give this a try too

Okay yay! You're welcome. I'm glad pants is not broken 🙌