GitHub action running Pants: https://github.com/robofit/arcor2/blob/master/.github/workflows/pants.yaml

… actually. sorry. it depends on whether

git diff --name-only

does the right thing when the contents have not been fetched.

but regardless, i think that we could definitely add support for either 1) poking

git-lfs

after doing a

--changed

calculation, 2) poking

git-lfs

while expanding globs

@narrow-activity-17405: in the meantime though, do know that you can split this and do something like:

./pants --changed-since=origin/master --changed-dependees=transitive filedeps --transitive

to get all affected files, make sure that

git-lfs

has materialized them, and then pass the list of files in to

./pants test

as a file with --spec-files

2) poking 

git-lfs

 while expanding globs

and… actually, this is maybe workable from a performance perspective, now that i think about it. if there are placeholder files, you don’t need to ask

git-lfs

to materialize them unless you want to capture their content: and that is a separate operation where it wouldn’t be too bad to interact with

git-lfs

(especially if you were able to do it lazily, where you only poked

git-lfs

if after capturing the file it was shaped like a placeholder file… i.e. contained a hash or w/e)

Actually, tests are not directly depending on LFS files. It is one of their

runtime_package_dependencies

which needs them.

@witty-crayon-22786 Thanks for info and tips. Not sure if I got everything right, but at least I tried to run

./pants --changed-since=origin/master --changed-dependees=transitive filedeps --transitive

and it gives me quite a lot of files even when there are no changes - is this expected? :-)

you can look at the “root” things that were identified by just running

./pants --changed-since=origin/master list

the two different “transitive” flags walk up and down from the roots, respectively