Is it possible to manually define additional dependencies for a third-party dependency somehow? I have a third-party dependency (

mongomock

) that requires

setuptools

to work, but it isn't defined as a requirement and thus not added to the pex by Pants. Right now I work around it by explicitly adding

setuptools

as a dependency to all the

python_library()

with code that uses

mongomock

, but it would be nice if I somehow could tell Pants to always pull in

setuptools

when something wants

mongomock

.

I imagine you could manually define a

python_requirement_library

for

mongomock

and add a dependency on

setuptools

Yeah, we do use

python_requirements

, so I imagine it clashing with

python_requirement_library

one way or another. Worth giving it a shot though and see what happens :)

if there ends up being a conflict, straightforward enough to do a PR to modify

python_requirements

to support excluding certain packages

You could remove

mongomock

from the

requirements.txt

that

python_requirements

references?

Concretely, this leads to a passing test in the Pants repo:

^jsirois@gill ~/dev/pantsbuild/jsirois-pants (main *) $ cat 3rdparty/python/BUILD.mongomock 
python_requirement_library(
  name="mongomock-fixed",
  requirements=["mongomock", "pymongo"],
  dependencies=["3rdparty/python:setuptools"],
)

^jsirois@gill ~/dev/pantsbuild/jsirois-pants (main *) $ cat src/python/pants/mongomock/BUILD 
python_tests(name='tests')
^jsirois@gill ~/dev/pantsbuild/jsirois-pants (main *) $ cat src/python/pants/mongomock/mongomock_test.py 
import mongomock


@mongomock.patch(servers=(('<http://server.example.com|server.example.com>', 27017),))
def test_test():
    pass

For

./pants test src/python/pants/mongomock/mongomock_test.py

.

And note that you can provide version constraints and so on in the

requirements=[...]

bit.

Thanks everyone. Currently we generate a

requirements.txt

from a

pyproject.toml

so Poetry's venv can still be used for the dependencies in PyCharm etc. - so we could simply remove

mongomock

from the

requirements.txt

and add it manually with

python_requirement_library

as you suggest. We do however currently use the same

requirements.txt

as the source for

requirement_constraints

, and that would still require

mongomock

in the file to work, correct? We could generate two files I suppose and remove

mongomock

from one of them, but the plan was to migrate to the new

poetry_requirements

macro, but I get the feeling that it would at this point cause more harm than good if I want to make my

mongomock

life eaiser 🙂

@narrow-vegetable-37489 how do you generate

requirement_constraints

? Do you use (loose) requirements straight from requirements.txt or do you use a script like the one suggested here to generate a pinned constraints file to simulate a lock file? I'm guessing the former. The latter though would work with part of your requirements being in requirements.txt and part being in

python_requirement_library

targets.

I use

poetry export --without-hashes

for the requirements.txt. If I export with hashes in a separate file for

requirement_constraints

and then run for example

./pants fmt ::

, Pants (or rather pip) complains that hashes are required for all dependencies and

docformatter

does not have any - but that's a separate issue 🙂

Ok. No simple solution then that I can think of.

You can include a

requirements.txt

in another one with

-r

right? And I think Pants will ignore those lines? Maybe there's a workaround there somehow