thread about naming things for the lockfile project lockfil Pants #general

Join Slack

:thread: about naming things for the lockfile proj...

# general

hundreds-father-404

08/27/2021, 1:48 AM

🧵 about naming things for the lockfile project, "lockfile" vs "resolve":

hundreds-father-404

08/27/2021, 1:49 AM

I've been using "lockfile" this whole time, but @witty-crayon-22786 has been encouraging "resolve". I think I better understand why now. The idea of "named resolves" makes it more obvious to me, where you define a couple blessed resolves in `pants.toml`:

Copy code

[python-setup.thirdparty_resolves]
default = "3rdparty/default_lockfile.txt"
py2 = "3rdparty/py2_lockfile.txt"

Then targets optionally choose which resolve to use:

Copy code

pex_binary(..., resolve="py2")

Using the name "resolve" shifts the focus from a file on disk to instead what that lockfile represents, like your "py2" lockfile or "data-science" lockfile does that sound right @witty-crayon-22786?

witty-crayon-22786

08/27/2021, 1:51 AM

yep. and a lockfile is just the on-disk representation of a resolve. the lockfile doesn’t exist without the resolve

👍 2

hundreds-father-404

08/27/2021, 1:52 AM

If we want to use "resolve" over "lockfile" in most places, I think the naming would be for now: •

[python-setup].resolves

[python-setup].thirdparty_resolves

•

resolve

field • I think still

./pants generate-lockfiles

, given that you're not creating any new resolves - you're updating the on-disk file the resolves refer to • but then it would be

./pants generate-lockfiles --resolves=['black', 'py2']

to only do for certain resolves thoughts @witty-crayon-22786?

👍 1

witty-crayon-22786

08/27/2021, 2:12 AM

sounds reasonable.

4 Views

Open in Slack

Previous Next