Hi! I’m migrating a monorepo from custom tooling (

poetry

,

nox

+ custom scripts) to pants, and I’m facing problems in how to configure tests. We mark some tests as

integration

and these are usually not run locally but only in the CI; in the past, our nox configuration took care of this by adding

-m 'not integration

when running the normal tests and we would have a special “target” to run full tests. I am not sure which is the best pattern to use in pants to achieve this. My first approach was to do something like

python_tests(
        name="tests",
        sources=["tests/**/*.py"],
        extra_env_vars=["PYTEST_ADDOPTS=-m 'not integration'"],
        **tests_kwargs,
    )

and then create a

tests_full

without the extra env vars, but this doesn’t work when I run

./pants test lib:tests

, because the skipped tests give a return code 5 in

pytests

. What would be another solution to achieve this?

Hi! A common pattern is to partition the targets themselves. So you have

python_tests(
  name="unit", 
  sources=[...]
)

python_tests(
  name="integration", 
  sources=[...],
  tags=["integration"],
)

oh, I see

If you're interested, we could help you write a small plugin to add the goals

unit

and

it

maybe? They would behave like

test

but automatically apply the filter for you

ahh, interesting! I will first use the tags approach and once my whole repo is migrated I’ll start writing plugins

Unfortunately I think macros cannot currently look at the filesystem. But we are looking into making BUILD file macros much more powerful, and able to invoke engine operations (such as filesystem access).

I’ll reheck, I may have tried with a different type of target

You can use the

ignore_warnings

global option: https://www.pantsbuild.org/docs/reference-global#section-ignore-warnings

I was trying this, and I don’t see a way of “selectively” ignoring warnings? For example,

Do the file(s) exist? If so, check if the file(s) are in your `.gitignore` or the global `pants_ignore` option, which may result in Pants not being able to see the file(s) even though they exist on disk. Refer to <https://www.pantsbuild.org/v2.6/docs/troubleshooting#pants-cannot-find-a-file-in-your-project>.
11:28:14.18 [WARN] Unmatched glob from lib/notifications:unit's `sources` field: "lib/notifications/tests/unit/*.py"

Do the file(s) exist? If so, check if the file(s) are in your `.gitignore` or the global `pants_ignore` option, which may result in Pants not being able to see the file(s) even though they exist on disk. Refer to <https://www.pantsbuild.org/v2.6/docs/troubleshooting#pants-cannot-find-a-file-in-your-project>.
11:28:14.26 [WARN] The target app/csv_importer imports `clickhouse_driver.errors.Error`, but Pants cannot safely infer a dependency because more than one target owns this module, so it is ambiguous which to use: ['app/csv_importer:clickhouse-driver', 'lib/common:clickhouse-driver'].

The first one is a well understood side effect of the discussion we had above, the bottom one is a config mistake (why is it a WARN and not an error?)

Hmm, you should be able to ignore only the warnings that match a regex?